scsi: use host wide tags by default
This patch changes the !blk-mq path to the same defaults as the blk-mq I/O path by always enabling block tagging, and always using host wide tags. We've had blk-mq available for a few releases so bugs with this mode should have been ironed out, and this ensures we get better coverage of over tagging setup over different configs. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Jens Axboe <axboe@kernel.dk> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: James Bottomley <JBottomley@Odin.com>
This commit is contained in:

committed by
James Bottomley

parent
720ba808e9
commit
64d513ac31
@@ -124,7 +124,6 @@ static struct scsi_host_template snic_host_template = {
|
||||
.sg_tablesize = SNIC_MAX_SG_DESC_CNT,
|
||||
.max_sectors = 0x800,
|
||||
.shost_attrs = snic_attrs,
|
||||
.use_blk_tags = 1,
|
||||
.track_queue_depth = 1,
|
||||
.cmd_size = sizeof(struct snic_internal_io_state),
|
||||
.proc_name = "snic_scsi",
|
||||
@@ -533,15 +532,6 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
|
||||
|
||||
snic->max_tag_id = shost->can_queue;
|
||||
|
||||
ret = scsi_init_shared_tag_map(shost, snic->max_tag_id);
|
||||
if (ret) {
|
||||
SNIC_HOST_ERR(shost,
|
||||
"Unable to alloc shared tag map. %d\n",
|
||||
ret);
|
||||
|
||||
goto err_dev_close;
|
||||
}
|
||||
|
||||
shost->max_lun = snic->config.luns_per_tgt;
|
||||
shost->max_id = SNIC_MAX_TARGET;
|
||||
|
||||
|
Reference in New Issue
Block a user