xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xfs: remove explicit xfs_sync_data/xfs_sync_attr calls on umount

Browse Source 
On the final put of a superblock the VFS already calls sync_filesystem
for us to write out all data and wait for it.  No need to start another
asynchronous writeback inside ->put_super.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
This commit is contained in:
Christoph Hellwig
2010-06-24 11:45:34 +10:00
committed by Alex Elder
parent f2bde9b89b
commit 64c8614941
3 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fs/xfs/linux-2.6/xfs_super.c
View File

@@ -1146,18 +1146,6 @@ xfs_fs_put_super(
xfs_syncd_stop(mp);
if (!(sb->s_flags & MS_RDONLY)) {
/*
* XXX(hch): this should be SYNC_WAIT.
*
* Or more likely not needed at all because the VFS is already
* calling ->sync_fs after shutting down all filestem
* operations and just before calling ->put_super.
*/
xfs_sync_data(mp, 0);
xfs_sync_attr(mp, 0);
}
/*
* Blow away any referenced inode in the filestreams cache.
* This can and will cause log traffic as inodes go inactive