net/8390: Fix msg_enable patch snafu
The lib8390 module parameter 'msg_enable' doesn't do anything useful:
it causes an ancient version string to be logged.
Remove redundant code that logs the same string.
In ne.c and wd.c, the value of ei_local->msg_enable is used before
being assigned. Use ne_msg_enable and wd_msg_enable, respectively.
Most of the other 8390 drivers never assign ei_local->msg_enable.
Use the 'msg_enable' module parameter from lib8390 as the default
value.
Eliminate the pointless static and local variables.
Clean up an indentation mistake.
All of these issues originated from the same patch.
Cc: Russell King <linux@armlinux.org.uk>
Fixes: c45f812f02
("8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Этот коммит содержится в:

коммит произвёл
David S. Miller

родитель
73219de294
Коммит
646fe03b0d
@@ -77,8 +77,6 @@ static unsigned char version[] = "ax88796.c: Copyright 2005,2007 Simtec Electron
|
||||
|
||||
#define AX_GPOC_PPDSET BIT(6)
|
||||
|
||||
static u32 ax_msg_enable;
|
||||
|
||||
/* device private data */
|
||||
|
||||
struct ax_device {
|
||||
@@ -747,7 +745,6 @@ static int ax_init_dev(struct net_device *dev)
|
||||
ei_local->block_output = &ax_block_output;
|
||||
ei_local->get_8390_hdr = &ax_get_8390_hdr;
|
||||
ei_local->priv = 0;
|
||||
ei_local->msg_enable = ax_msg_enable;
|
||||
|
||||
dev->netdev_ops = &ax_netdev_ops;
|
||||
dev->ethtool_ops = &ax_ethtool_ops;
|
||||
|
Ссылка в новой задаче
Block a user