ethernet: Remove casts to same type
Adding casts of objects to the same type is unnecessary and confusing for a human reader. For example, this cast: int y; int *p = (int *)&y; I used the coccinelle script below to find and remove these unnecessary casts. I manually removed the conversions this script produces of casts with __force, __iomem and __user. @@ type T; T *p; @@ - (T *)p + p A function in atl1e_main.c was passed a const pointer when it actually modified elements of the structure. Change the argument to a non-const pointer. A function in stmmac needed a __force to avoid a sparse warning. Added it. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
20d5ec435c
commit
6469933605
@@ -583,7 +583,7 @@ static inline void ioc3_rx(struct net_device *dev)
|
||||
unsigned long *rxr;
|
||||
u32 w0, err;
|
||||
|
||||
rxr = (unsigned long *) ip->rxr; /* Ring base */
|
||||
rxr = ip->rxr; /* Ring base */
|
||||
rx_entry = ip->rx_ci; /* RX consume index */
|
||||
n_entry = ip->rx_pi;
|
||||
|
||||
@@ -903,7 +903,7 @@ static void ioc3_alloc_rings(struct net_device *dev)
|
||||
if (ip->rxr == NULL) {
|
||||
/* Allocate and initialize rx ring. 4kb = 512 entries */
|
||||
ip->rxr = (unsigned long *) get_zeroed_page(GFP_ATOMIC);
|
||||
rxr = (unsigned long *) ip->rxr;
|
||||
rxr = ip->rxr;
|
||||
if (!rxr)
|
||||
printk("ioc3_alloc_rings(): get_zeroed_page() failed!\n");
|
||||
|
||||
|
Reference in New Issue
Block a user