ethernet: Remove casts to same type
Adding casts of objects to the same type is unnecessary and confusing for a human reader. For example, this cast: int y; int *p = (int *)&y; I used the coccinelle script below to find and remove these unnecessary casts. I manually removed the conversions this script produces of casts with __force, __iomem and __user. @@ type T; T *p; @@ - (T *)p + p A function in atl1e_main.c was passed a const pointer when it actually modified elements of the structure. Change the argument to a non-const pointer. A function in stmmac needed a __force to avoid a sparse warning. Added it. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
20d5ec435c
commit
6469933605
@@ -3973,7 +3973,7 @@ DevicePresent(struct net_device *dev, u_long aprom_addr)
|
||||
tmp = srom_rd(aprom_addr, i);
|
||||
*p++ = cpu_to_le16(tmp);
|
||||
}
|
||||
de4x5_dbg_srom((struct de4x5_srom *)&lp->srom);
|
||||
de4x5_dbg_srom(&lp->srom);
|
||||
}
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user