memory: omap-gpmc: Add Kconfig option for debug
We support decoding the bootloader values if DEBUG is defined. But we also need to change the struct omap_hwmod flags to have HWMOD_INIT_NO_RESET to avoid the GPMC being reset during the boot. Otherwise just the default timings will be displayed instead of the bootloader configured timings. This also allows us to clean up the various GPMC related hwmod flags. For debugging, we only need HWMOD_INIT_NO_RESET, and HWMOD_INIT_NO_IDLE is not needed. Cc: Brian Hutchinson <b.hutchman@gmail.com> Cc: Paul Walmsley <paul@pwsan.com> Cc: Roger Quadros <rogerq@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Paul Walmsley <paul@pwsan.com>
This commit is contained in:

committed by
Paul Walmsley

vanhempi
e26081808e
commit
63aa945b10
@@ -49,6 +49,14 @@ config OMAP_GPMC
|
||||
interfacing to a variety of asynchronous as well as synchronous
|
||||
memory drives like NOR, NAND, OneNAND, SRAM.
|
||||
|
||||
config OMAP_GPMC_DEBUG
|
||||
bool
|
||||
depends on OMAP_GPMC
|
||||
help
|
||||
Enables verbose debugging mostly to decode the bootloader provided
|
||||
timings. Enable this during development to configure devices
|
||||
connected to the GPMC bus.
|
||||
|
||||
config MVEBU_DEVBUS
|
||||
bool "Marvell EBU Device Bus Controller"
|
||||
default y
|
||||
|
@@ -403,7 +403,7 @@ static void gpmc_cs_bool_timings(int cs, const struct gpmc_bool_timings *p)
|
||||
p->cycle2cyclediffcsen);
|
||||
}
|
||||
|
||||
#ifdef DEBUG
|
||||
#ifdef CONFIG_OMAP_GPMC_DEBUG
|
||||
/**
|
||||
* get_gpmc_timing_reg - read a timing parameter and print DTS settings for it.
|
||||
* @cs: Chip Select Region
|
||||
@@ -612,7 +612,7 @@ static int set_gpmc_timing_reg(int cs, int reg, int st_bit, int end_bit, int max
|
||||
}
|
||||
|
||||
l = gpmc_cs_read_reg(cs, reg);
|
||||
#ifdef DEBUG
|
||||
#ifdef CONFIG_OMAP_GPMC_DEBUG
|
||||
pr_info(
|
||||
"GPMC CS%d: %-17s: %3d ticks, %3lu ns (was %3i ticks) %3d ns\n",
|
||||
cs, name, ticks, gpmc_get_clk_period(cs, cd) * ticks / 1000,
|
||||
@@ -767,7 +767,7 @@ int gpmc_cs_set_timings(int cs, const struct gpmc_timings *t,
|
||||
GPMC_CONFIG1_CLKACTIVATIONTIME_MAX,
|
||||
clk_activation, GPMC_CD_FCLK);
|
||||
|
||||
#ifdef DEBUG
|
||||
#ifdef CONFIG_OMAP_GPMC_DEBUG
|
||||
pr_info("GPMC CS%d CLK period is %lu ns (div %d)\n",
|
||||
cs, (div * gpmc_get_fclk_period()) / 1000, div);
|
||||
#endif
|
||||
|
Viittaa uudesa ongelmassa
Block a user