pinctrl: meson: remove offset from pinctrl
Offset on meson pinctrl and gpios is something that was carried from the vendor driver, where there is a weird link between the 2 controllers. Since these 2 controllers are independent, this offset adds an unnecessary complexity. This patch remove this manually set offset and rely on pinctrl to figure out the gpio base offset Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:

committad av
Linus Walleij

förälder
505485a83c
incheckning
634e40b0c2
@@ -410,18 +410,6 @@ static const struct pinconf_ops meson_pinconf_ops = {
|
||||
.is_generic = true,
|
||||
};
|
||||
|
||||
static int meson_gpio_request(struct gpio_chip *chip, unsigned gpio)
|
||||
{
|
||||
return pinctrl_request_gpio(chip->base + gpio);
|
||||
}
|
||||
|
||||
static void meson_gpio_free(struct gpio_chip *chip, unsigned gpio)
|
||||
{
|
||||
struct meson_pinctrl *pc = gpiochip_get_data(chip);
|
||||
|
||||
pinctrl_free_gpio(pc->data->pin_base + gpio);
|
||||
}
|
||||
|
||||
static int meson_gpio_direction_input(struct gpio_chip *chip, unsigned gpio)
|
||||
{
|
||||
struct meson_pinctrl *pc = gpiochip_get_data(chip);
|
||||
@@ -539,13 +527,13 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc)
|
||||
|
||||
pc->chip.label = pc->data->name;
|
||||
pc->chip.parent = pc->dev;
|
||||
pc->chip.request = meson_gpio_request;
|
||||
pc->chip.free = meson_gpio_free;
|
||||
pc->chip.request = gpiochip_generic_request;
|
||||
pc->chip.free = gpiochip_generic_free;
|
||||
pc->chip.direction_input = meson_gpio_direction_input;
|
||||
pc->chip.direction_output = meson_gpio_direction_output;
|
||||
pc->chip.get = meson_gpio_get;
|
||||
pc->chip.set = meson_gpio_set;
|
||||
pc->chip.base = pc->data->pin_base;
|
||||
pc->chip.base = -1;
|
||||
pc->chip.ngpio = pc->data->num_pins;
|
||||
pc->chip.can_sleep = false;
|
||||
pc->chip.of_node = pc->of_node;
|
||||
|
Referens i nytt ärende
Block a user