ath5k: disable 32KHz sleep clock operation by default
While 32 KHz sleep clock might provide some power saving benefits, it is also a major source of stability issues, on OpenWrt it produced some reproducible data bus errors on register accesses on several different MIPS platforms. All the Atheros drivers that I can find do not enable this feature, so it makes sense to leave it disabled in ath5k as well. Signed-off-by: Felix Fietkau <nbd@openwrt.org> Acked-by: Nick Kossifidis <mickflemm@gmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:

committed by
John W. Linville

父節點
f00643888c
當前提交
6340211c5f
@@ -1287,11 +1287,16 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode,
|
||||
ath5k_hw_dma_init(ah);
|
||||
|
||||
|
||||
/* Enable 32KHz clock function for AR5212+ chips
|
||||
/*
|
||||
* Enable 32KHz clock function for AR5212+ chips
|
||||
* Set clocks to 32KHz operation and use an
|
||||
* external 32KHz crystal when sleeping if one
|
||||
* exists */
|
||||
if (ah->ah_version == AR5K_AR5212 &&
|
||||
* exists.
|
||||
* Disabled by default because it is also disabled in
|
||||
* other drivers and it is known to cause stability
|
||||
* issues on some devices
|
||||
*/
|
||||
if (ah->ah_use_32khz_clock && ah->ah_version == AR5K_AR5212 &&
|
||||
op_mode != NL80211_IFTYPE_AP)
|
||||
ath5k_hw_set_sleep_clock(ah, true);
|
||||
|
||||
|
Reference in New Issue
Block a user