xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: netsec: fix error handling in netsec_register_mdio()

Browse Source 
[ Upstream commit 94423589689124e8cd145b38a1034be7f25835b2 ]

If phy_device_register() fails, phy_device_free() need be called to
put refcount, so memory of phy device and device name can be freed
in callback function.

If get_phy_device() fails, mdiobus_unregister() need be called,
or it will cause warning in mdiobus_free() and kobject is leaked.

Fixes: 533dd11a12 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221019064104.3228892-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Yang Yingliang
2022-10-19 14:41:04 +08:00
committed by Greg Kroah-Hartman
parent 32a3d4660b
commit 62f0a08e82
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/socionext/netsec.c
View File

@@ -1958,11 +1958,13 @@ static int netsec_register_mdio(struct netsec_priv *priv, u32 phy_addr)
ret = PTR_ERR(priv->phydev); ret = PTR_ERR(priv->phydev);
dev_err(priv->dev, "get_phy_device err(%d)\n", ret); dev_err(priv->dev, "get_phy_device err(%d)\n", ret);
priv->phydev = NULL; priv->phydev = NULL;
mdiobus_unregister(bus);
return -ENODEV; return -ENODEV;
} }
ret = phy_device_register(priv->phydev); ret = phy_device_register(priv->phydev);
if (ret) { if (ret) {
phy_device_free(priv->phydev);
mdiobus_unregister(bus); mdiobus_unregister(bus);
dev_err(priv->dev, dev_err(priv->dev,
"phy_device_register err(%d)\n", ret); "phy_device_register err(%d)\n", ret);