net: add {READ|WRITE}_ONCE() annotations on ->rskq_accept_head
reqsk_queue_empty() is called from inet_csk_listen_poll() while
other cpus might write ->rskq_accept_head value.
Use {READ|WRITE}_ONCE() to avoid compiler tricks
and potential KCSAN splats.
Fixes: fff1f3001c
("tcp: add a spinlock to protect struct request_sock_queue")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
此提交包含在:
@@ -185,7 +185,7 @@ void reqsk_fastopen_remove(struct sock *sk, struct request_sock *req,
|
||||
|
||||
static inline bool reqsk_queue_empty(const struct request_sock_queue *queue)
|
||||
{
|
||||
return queue->rskq_accept_head == NULL;
|
||||
return READ_ONCE(queue->rskq_accept_head) == NULL;
|
||||
}
|
||||
|
||||
static inline struct request_sock *reqsk_queue_remove(struct request_sock_queue *queue,
|
||||
@@ -197,7 +197,7 @@ static inline struct request_sock *reqsk_queue_remove(struct request_sock_queue
|
||||
req = queue->rskq_accept_head;
|
||||
if (req) {
|
||||
sk_acceptq_removed(parent);
|
||||
queue->rskq_accept_head = req->dl_next;
|
||||
WRITE_ONCE(queue->rskq_accept_head, req->dl_next);
|
||||
if (queue->rskq_accept_head == NULL)
|
||||
queue->rskq_accept_tail = NULL;
|
||||
}
|
||||
|
新增問題並參考
封鎖使用者