xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ANDROID: xt_quota2: clear quota2_log message before sending

Browse Source 
Initialize message buffer for quota2_log to avoid sending
random data.

Bug: 196046570
Test: passed netd test suites
Fixes: 10cda83af9 ("ANDROID: netfilter: xt_quota2: adding the
original quota2 from xtables-addons")
Signed-off-by: Todd Kjos <tkjos@google.com>
Change-Id: Ic9f34aaa2593809b375fc649b74567190c99dc62
This commit is contained in:
Todd Kjos
2021-08-17 13:29:23 -07:00
parent 4b05a506bd
commit 60a4c35570
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
net/netfilter/xt_quota2.c
View File

@@ -106,23 +106,16 @@ static void quota2_log(unsigned int hooknum,
return; return;
} }
pm = nlmsg_data(nlh); pm = nlmsg_data(nlh);
memset(pm, 0, sizeof(*pm));
if (skb->tstamp == 0) if (skb->tstamp == 0)
__net_timestamp((struct sk_buff *)skb); __net_timestamp((struct sk_buff *)skb);
pm->data_len = 0;
pm->hook = hooknum; pm->hook = hooknum;
if (prefix != NULL) if (prefix != NULL)
strlcpy(pm->prefix, prefix, sizeof(pm->prefix)); strlcpy(pm->prefix, prefix, sizeof(pm->prefix));
else
*(pm->prefix) = '\0';
if (in) if (in)
strlcpy(pm->indev_name, in->name, sizeof(pm->indev_name)); strlcpy(pm->indev_name, in->name, sizeof(pm->indev_name));
else
pm->indev_name[0] = '\0';
if (out) if (out)
strlcpy(pm->outdev_name, out->name, sizeof(pm->outdev_name)); strlcpy(pm->outdev_name, out->name, sizeof(pm->outdev_name));
else
pm->outdev_name[0] = '\0';
NETLINK_CB(log_skb).dst_group = 1; NETLINK_CB(log_skb).dst_group = 1;
pr_debug("throwing 1 packets to netlink group 1\n"); pr_debug("throwing 1 packets to netlink group 1\n");