BKL: Remove BKL from OCFS2
The BKL in ocfs2/dlmfs is used in put_super, fill_super and remount_fs that are all three protected by the superblocks s_umount rw_semaphore. The use in ocfs2_control_open is evidently unrelated and the function is protected by ocfs2_control_lock. Therefore it is safe to remove the BKL entirely. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Mark Fasheh <mfasheh@suse.com> Cc: Joel Becker <joel.becker@oracle.com>
This commit is contained in:
@@ -22,7 +22,6 @@
|
||||
#include <linux/miscdevice.h>
|
||||
#include <linux/mutex.h>
|
||||
#include <linux/slab.h>
|
||||
#include <linux/smp_lock.h>
|
||||
#include <linux/reboot.h>
|
||||
#include <asm/uaccess.h>
|
||||
|
||||
@@ -612,12 +611,10 @@ static int ocfs2_control_open(struct inode *inode, struct file *file)
|
||||
return -ENOMEM;
|
||||
p->op_this_node = -1;
|
||||
|
||||
lock_kernel();
|
||||
mutex_lock(&ocfs2_control_lock);
|
||||
file->private_data = p;
|
||||
list_add(&p->op_list, &ocfs2_control_private_list);
|
||||
mutex_unlock(&ocfs2_control_lock);
|
||||
unlock_kernel();
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
Reference in New Issue
Block a user