[PATCH] mark struct file_operations const 2
Many struct file_operations in the kernel can be "const". Marking them const moves these to the .rodata section, which avoids false sharing with potential dirty data. In addition it'll catch accidental writes at compile time to these shared resources. [akpm@osdl.org: sparc64 fix] Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
540473208f
commit
5dfe4c964a
@@ -352,7 +352,7 @@ retry:
|
||||
return size;
|
||||
}
|
||||
|
||||
static struct file_operations salinfo_event_fops = {
|
||||
static const struct file_operations salinfo_event_fops = {
|
||||
.open = salinfo_event_open,
|
||||
.read = salinfo_event_read,
|
||||
};
|
||||
@@ -568,7 +568,7 @@ salinfo_log_write(struct file *file, const char __user *buffer, size_t count, lo
|
||||
return count;
|
||||
}
|
||||
|
||||
static struct file_operations salinfo_data_fops = {
|
||||
static const struct file_operations salinfo_data_fops = {
|
||||
.open = salinfo_log_open,
|
||||
.release = salinfo_log_release,
|
||||
.read = salinfo_log_read,
|
||||
|
Reference in New Issue
Block a user