xen/grants: prevent integer overflow in gnttab_dma_alloc_pages()
[ Upstream commit e9ea0b30ada008f4e65933f449db6894832cb242 ]
The change from kcalloc() to kvmalloc() means that arg->nr_pages
might now be large enough that the "args->nr_pages << PAGE_SHIFT" can
result in an integer overflow.
Fixes: b3f7931f5c
("xen/gntdev: switch from kcalloc() to kvcalloc()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/YxDROJqu/RPvR0bi@kili
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
eb0c614c42
commit
5d0d46e625
@@ -981,6 +981,9 @@ int gnttab_dma_alloc_pages(struct gnttab_dma_alloc_args *args)
|
|||||||
size_t size;
|
size_t size;
|
||||||
int i, ret;
|
int i, ret;
|
||||||
|
|
||||||
|
if (args->nr_pages < 0 || args->nr_pages > (INT_MAX >> PAGE_SHIFT))
|
||||||
|
return -ENOMEM;
|
||||||
|
|
||||||
size = args->nr_pages << PAGE_SHIFT;
|
size = args->nr_pages << PAGE_SHIFT;
|
||||||
if (args->coherent)
|
if (args->coherent)
|
||||||
args->vaddr = dma_alloc_coherent(args->dev, size,
|
args->vaddr = dma_alloc_coherent(args->dev, size,
|
||||||
|
Reference in New Issue
Block a user