soc/qman: add return value to interrupt coalesce changing APIs
Check that the values received by the portal interrupt coalesce change APIs are in range. Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> Signed-off-by: Roy Pledge <roy.pledge@nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
830b61ba4e
commit
5c664ace8c
@@ -36,6 +36,8 @@
|
||||
#define MAX_IRQNAME 16 /* big enough for "QMan portal %d" */
|
||||
#define QMAN_POLL_LIMIT 32
|
||||
#define QMAN_PIRQ_DQRR_ITHRESH 12
|
||||
#define QMAN_DQRR_IT_MAX 15
|
||||
#define QMAN_ITP_MAX 0xFFF
|
||||
#define QMAN_PIRQ_MR_ITHRESH 4
|
||||
#define QMAN_PIRQ_IPERIOD 100
|
||||
|
||||
@@ -727,9 +729,15 @@ static inline void qm_dqrr_vdqcr_set(struct qm_portal *portal, u32 vdqcr)
|
||||
qm_out(portal, QM_REG_DQRR_VDQCR, vdqcr);
|
||||
}
|
||||
|
||||
static inline void qm_dqrr_set_ithresh(struct qm_portal *portal, u8 ithresh)
|
||||
static inline int qm_dqrr_set_ithresh(struct qm_portal *portal, u8 ithresh)
|
||||
{
|
||||
|
||||
if (ithresh > QMAN_DQRR_IT_MAX)
|
||||
return -EINVAL;
|
||||
|
||||
qm_out(portal, QM_REG_DQRR_ITR, ithresh);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* --- MR API --- */
|
||||
@@ -1012,13 +1020,20 @@ static inline void put_affine_portal(void)
|
||||
|
||||
static struct workqueue_struct *qm_portal_wq;
|
||||
|
||||
void qman_dqrr_set_ithresh(struct qman_portal *portal, u8 ithresh)
|
||||
int qman_dqrr_set_ithresh(struct qman_portal *portal, u8 ithresh)
|
||||
{
|
||||
if (!portal)
|
||||
return;
|
||||
int res;
|
||||
|
||||
if (!portal)
|
||||
return -EINVAL;
|
||||
|
||||
res = qm_dqrr_set_ithresh(&portal->p, ithresh);
|
||||
if (res)
|
||||
return res;
|
||||
|
||||
qm_dqrr_set_ithresh(&portal->p, ithresh);
|
||||
portal->p.dqrr.ithresh = ithresh;
|
||||
|
||||
return 0;
|
||||
}
|
||||
EXPORT_SYMBOL(qman_dqrr_set_ithresh);
|
||||
|
||||
@@ -1036,10 +1051,14 @@ void qman_portal_get_iperiod(struct qman_portal *portal, u32 *iperiod)
|
||||
}
|
||||
EXPORT_SYMBOL(qman_portal_get_iperiod);
|
||||
|
||||
void qman_portal_set_iperiod(struct qman_portal *portal, u32 iperiod)
|
||||
int qman_portal_set_iperiod(struct qman_portal *portal, u32 iperiod)
|
||||
{
|
||||
if (portal)
|
||||
qm_out(&portal->p, QM_REG_ITPR, iperiod);
|
||||
if (!portal || iperiod > QMAN_ITP_MAX)
|
||||
return -EINVAL;
|
||||
|
||||
qm_out(&portal->p, QM_REG_ITPR, iperiod);
|
||||
|
||||
return 0;
|
||||
}
|
||||
EXPORT_SYMBOL(qman_portal_set_iperiod);
|
||||
|
||||
|
Reference in New Issue
Block a user