x86/module: Use text_mutex in apply_relocate_add()

Now that the livepatch code no longer needs the text_mutex for changing
module permissions, move its usage down to apply_relocate_add().

Note the s390 version of apply_relocate_add() doesn't need to use the
text_mutex because it already uses s390_kernel_write_lock, which
accomplishes the same task.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Josh Poimboeuf
2020-04-29 10:24:52 -05:00
committed by Jiri Kosina
parent 0d9fbf78fe
commit 5b384f9335
2 changed files with 7 additions and 8 deletions

View File

@@ -775,9 +775,6 @@ static int klp_init_object_loaded(struct klp_patch *patch,
int ret;
if (klp_is_module(obj)) {
mutex_lock(&text_mutex);
/*
* Only write module-specific relocations here
* (.klp.rela.{module}.*). vmlinux-specific relocations were
@@ -785,9 +782,6 @@ static int klp_init_object_loaded(struct klp_patch *patch,
* itself.
*/
ret = klp_apply_object_relocs(patch, obj);
mutex_unlock(&text_mutex);
if (ret)
return ret;
}