xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tpm/tpm_ftpm_tee: Fix error handling in ftpm_mod_init()

Browse Source 
[ Upstream commit 2b7d07f7acaac2c7750e420dcf4414588ede6d03 ]

The ftpm_mod_init() returns the driver_register() directly without checking
its return value, if driver_register() failed, the ftpm_tee_plat_driver is
not unregistered.

Fix by unregister ftpm_tee_plat_driver when driver_register() failed.

Fixes: 9f1944c23c ("tpm_ftpm_tee: register driver on TEE bus")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Maxim Uvarov <maxim.uvarov@linaro.org>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Yuan Can
2022-11-24 03:19:26 +00:00
committed by Greg Kroah-Hartman
parent 295f59cd2c
commit 5b217f4e79
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/char/tpm/tpm_ftpm_tee.c
View File

@@ -397,7 +397,13 @@ static int __init ftpm_mod_init(void)
if (rc) if (rc)
return rc; return rc;
return driver_register(&ftpm_tee_driver.driver); rc = driver_register(&ftpm_tee_driver.driver);
if (rc) {
platform_driver_unregister(&ftpm_tee_plat_driver);
return rc;
}
return 0;
} }
static void __exit ftpm_mod_exit(void) static void __exit ftpm_mod_exit(void)