xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: axis - use a constant time tag compare

Browse Source 
Avoid plain memcmp() on the AEAD tag value as this could leak
information through a timing side channel.

Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Lars Persson
2019-01-23 12:59:45 +01:00
committed by Herbert Xu
parent 48ef0908b8
commit 5997a245c7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/crypto/axis/artpec6_crypto.c
View File

@@ -2201,9 +2201,9 @@ static void artpec6_crypto_complete_aead(struct crypto_async_request *req)
areq->assoclen + areq->cryptlen - areq->assoclen + areq->cryptlen -
authsize); authsize);
if (memcmp(req_ctx->decryption_tag, if (crypto_memneq(req_ctx->decryption_tag,
input_tag, input_tag,
authsize)) { authsize)) {
pr_debug("***EBADMSG:\n"); pr_debug("***EBADMSG:\n");
print_hex_dump_debug("ref:", DUMP_PREFIX_ADDRESS, 32, 1, print_hex_dump_debug("ref:", DUMP_PREFIX_ADDRESS, 32, 1,
input_tag, authsize, true); input_tag, authsize, true);