tun/tap: use ptr_ring instead of skb_array
This patch switches to use ptr_ring instead of skb_array. This will be used to enqueue different types of pointers by encoding type into lower bits. Signed-off-by: Jason Wang <jasowang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
a0ce093180
commit
5990a30510
@@ -179,7 +179,7 @@ struct tun_file {
|
||||
struct mutex napi_mutex; /* Protects access to the above napi */
|
||||
struct list_head next;
|
||||
struct tun_struct *detached;
|
||||
struct skb_array tx_array;
|
||||
struct ptr_ring tx_ring;
|
||||
struct xdp_rxq_info xdp_rxq;
|
||||
};
|
||||
|
||||
@@ -635,7 +635,7 @@ static void tun_queue_purge(struct tun_file *tfile)
|
||||
{
|
||||
struct sk_buff *skb;
|
||||
|
||||
while ((skb = skb_array_consume(&tfile->tx_array)) != NULL)
|
||||
while ((skb = ptr_ring_consume(&tfile->tx_ring)) != NULL)
|
||||
kfree_skb(skb);
|
||||
|
||||
skb_queue_purge(&tfile->sk.sk_write_queue);
|
||||
@@ -689,7 +689,8 @@ static void __tun_detach(struct tun_file *tfile, bool clean)
|
||||
unregister_netdevice(tun->dev);
|
||||
}
|
||||
if (tun) {
|
||||
skb_array_cleanup(&tfile->tx_array);
|
||||
ptr_ring_cleanup(&tfile->tx_ring,
|
||||
__skb_array_destroy_skb);
|
||||
xdp_rxq_info_unreg(&tfile->xdp_rxq);
|
||||
}
|
||||
sock_put(&tfile->sk);
|
||||
@@ -782,7 +783,7 @@ static int tun_attach(struct tun_struct *tun, struct file *file,
|
||||
}
|
||||
|
||||
if (!tfile->detached &&
|
||||
skb_array_init(&tfile->tx_array, dev->tx_queue_len, GFP_KERNEL)) {
|
||||
ptr_ring_init(&tfile->tx_ring, dev->tx_queue_len, GFP_KERNEL)) {
|
||||
err = -ENOMEM;
|
||||
goto out;
|
||||
}
|
||||
@@ -1048,7 +1049,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)
|
||||
|
||||
nf_reset(skb);
|
||||
|
||||
if (skb_array_produce(&tfile->tx_array, skb))
|
||||
if (ptr_ring_produce(&tfile->tx_ring, skb))
|
||||
goto drop;
|
||||
|
||||
/* Notify and wake up reader process */
|
||||
@@ -1316,7 +1317,7 @@ static unsigned int tun_chr_poll(struct file *file, poll_table *wait)
|
||||
|
||||
poll_wait(file, sk_sleep(sk), wait);
|
||||
|
||||
if (!skb_array_empty(&tfile->tx_array))
|
||||
if (!ptr_ring_empty(&tfile->tx_ring))
|
||||
mask |= POLLIN | POLLRDNORM;
|
||||
|
||||
if (tun->dev->flags & IFF_UP &&
|
||||
@@ -1966,7 +1967,7 @@ static struct sk_buff *tun_ring_recv(struct tun_file *tfile, int noblock,
|
||||
struct sk_buff *skb = NULL;
|
||||
int error = 0;
|
||||
|
||||
skb = skb_array_consume(&tfile->tx_array);
|
||||
skb = ptr_ring_consume(&tfile->tx_ring);
|
||||
if (skb)
|
||||
goto out;
|
||||
if (noblock) {
|
||||
@@ -1978,7 +1979,7 @@ static struct sk_buff *tun_ring_recv(struct tun_file *tfile, int noblock,
|
||||
current->state = TASK_INTERRUPTIBLE;
|
||||
|
||||
while (1) {
|
||||
skb = skb_array_consume(&tfile->tx_array);
|
||||
skb = ptr_ring_consume(&tfile->tx_ring);
|
||||
if (skb)
|
||||
break;
|
||||
if (signal_pending(current)) {
|
||||
@@ -2208,7 +2209,7 @@ static int tun_peek_len(struct socket *sock)
|
||||
if (!tun)
|
||||
return 0;
|
||||
|
||||
ret = skb_array_peek_len(&tfile->tx_array);
|
||||
ret = PTR_RING_PEEK_CALL(&tfile->tx_ring, __skb_array_len_with_tag);
|
||||
tun_put(tun);
|
||||
|
||||
return ret;
|
||||
@@ -3114,25 +3115,26 @@ static int tun_queue_resize(struct tun_struct *tun)
|
||||
{
|
||||
struct net_device *dev = tun->dev;
|
||||
struct tun_file *tfile;
|
||||
struct skb_array **arrays;
|
||||
struct ptr_ring **rings;
|
||||
int n = tun->numqueues + tun->numdisabled;
|
||||
int ret, i;
|
||||
|
||||
arrays = kmalloc_array(n, sizeof(*arrays), GFP_KERNEL);
|
||||
if (!arrays)
|
||||
rings = kmalloc_array(n, sizeof(*rings), GFP_KERNEL);
|
||||
if (!rings)
|
||||
return -ENOMEM;
|
||||
|
||||
for (i = 0; i < tun->numqueues; i++) {
|
||||
tfile = rtnl_dereference(tun->tfiles[i]);
|
||||
arrays[i] = &tfile->tx_array;
|
||||
rings[i] = &tfile->tx_ring;
|
||||
}
|
||||
list_for_each_entry(tfile, &tun->disabled, next)
|
||||
arrays[i++] = &tfile->tx_array;
|
||||
rings[i++] = &tfile->tx_ring;
|
||||
|
||||
ret = skb_array_resize_multiple(arrays, n,
|
||||
dev->tx_queue_len, GFP_KERNEL);
|
||||
ret = ptr_ring_resize_multiple(rings, n,
|
||||
dev->tx_queue_len, GFP_KERNEL,
|
||||
__skb_array_destroy_skb);
|
||||
|
||||
kfree(arrays);
|
||||
kfree(rings);
|
||||
return ret;
|
||||
}
|
||||
|
||||
@@ -3218,7 +3220,7 @@ struct socket *tun_get_socket(struct file *file)
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(tun_get_socket);
|
||||
|
||||
struct skb_array *tun_get_skb_array(struct file *file)
|
||||
struct ptr_ring *tun_get_tx_ring(struct file *file)
|
||||
{
|
||||
struct tun_file *tfile;
|
||||
|
||||
@@ -3227,9 +3229,9 @@ struct skb_array *tun_get_skb_array(struct file *file)
|
||||
tfile = file->private_data;
|
||||
if (!tfile)
|
||||
return ERR_PTR(-EBADFD);
|
||||
return &tfile->tx_array;
|
||||
return &tfile->tx_ring;
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(tun_get_skb_array);
|
||||
EXPORT_SYMBOL_GPL(tun_get_tx_ring);
|
||||
|
||||
module_init(tun_init);
|
||||
module_exit(tun_cleanup);
|
||||
|
Reference in New Issue
Block a user