iio: force snprintf for PAGE_SIZE bufs
This is a tiny preventative measure to make sure we can't write beyond PAGE_SIZE on the buffers being used in sysfs for iio. There is currently no way for this to happen, but the change makes this code more robust for the future. Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:

committad av
Jonathan Cameron

förälder
24e7d79901
incheckning
598db58166
@@ -340,7 +340,7 @@ ssize_t iio_enum_read(struct iio_dev *indio_dev,
|
||||
else if (i >= e->num_items)
|
||||
return -EINVAL;
|
||||
|
||||
return sprintf(buf, "%s\n", e->items[i]);
|
||||
return snprintf(buf, PAGE_SIZE, "%s\n", e->items[i]);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(iio_enum_read);
|
||||
|
||||
@@ -820,7 +820,7 @@ static ssize_t iio_show_dev_name(struct device *dev,
|
||||
char *buf)
|
||||
{
|
||||
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
|
||||
return sprintf(buf, "%s\n", indio_dev->name);
|
||||
return snprintf(buf, PAGE_SIZE, "%s\n", indio_dev->name);
|
||||
}
|
||||
|
||||
static DEVICE_ATTR(name, S_IRUGO, iio_show_dev_name, NULL);
|
||||
|
Referens i nytt ärende
Block a user