[DCCP]: Simplified conditions due to use of enum:8 states
This reaps the benefit of the earlier patch, which changed the type of CCID 3 states to use enums, in that many conditions are now simplified and the number of possible (unexpected) values is greatly reduced. In a few instances, this also allowed to simplify pre-conditions; where care has been taken to retain logical equivalence. [DCCP]: Introduce a consistent BUG/WARN message scheme This refines the existing set of DCCP messages so that * BUG(), BUG_ON(), WARN_ON() have meaningful DCCP-specific counterparts * DCCP_CRIT (for severe warnings) is not rate-limited * DCCP_WARN() is introduced as rate-limited wrapper Using these allows a faster and cleaner transition to their original counterparts once the code has matured into a full DCCP implementation. Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
This commit is contained in:

committed by
David S. Miller

parent
b1308dc015
commit
59348b19ef
@@ -1033,8 +1033,7 @@ static int __init dccp_init(void)
|
||||
} while (!dccp_hashinfo.ehash && --ehash_order > 0);
|
||||
|
||||
if (!dccp_hashinfo.ehash) {
|
||||
printk(KERN_CRIT "Failed to allocate DCCP "
|
||||
"established hash table\n");
|
||||
DCCP_CRIT("Failed to allocate DCCP established hash table");
|
||||
goto out_free_bind_bucket_cachep;
|
||||
}
|
||||
|
||||
@@ -1056,7 +1055,7 @@ static int __init dccp_init(void)
|
||||
} while (!dccp_hashinfo.bhash && --bhash_order >= 0);
|
||||
|
||||
if (!dccp_hashinfo.bhash) {
|
||||
printk(KERN_CRIT "Failed to allocate DCCP bind hash table\n");
|
||||
DCCP_CRIT("Failed to allocate DCCP bind hash table");
|
||||
goto out_free_dccp_ehash;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user