Merge remote-tracking branch 'regmap/topic/irq' into regmap-next
This commit is contained in:
@@ -44,6 +44,8 @@ struct regmap_irq_chip_data {
|
||||
|
||||
unsigned int irq_reg_stride;
|
||||
unsigned int type_reg_stride;
|
||||
|
||||
bool clear_status:1;
|
||||
};
|
||||
|
||||
static inline const
|
||||
@@ -77,6 +79,7 @@ static void regmap_irq_sync_unlock(struct irq_data *data)
|
||||
int i, ret;
|
||||
u32 reg;
|
||||
u32 unmask_offset;
|
||||
u32 val;
|
||||
|
||||
if (d->chip->runtime_pm) {
|
||||
ret = pm_runtime_get_sync(map->dev);
|
||||
@@ -85,6 +88,20 @@ static void regmap_irq_sync_unlock(struct irq_data *data)
|
||||
ret);
|
||||
}
|
||||
|
||||
if (d->clear_status) {
|
||||
for (i = 0; i < d->chip->num_regs; i++) {
|
||||
reg = d->chip->status_base +
|
||||
(i * map->reg_stride * d->irq_reg_stride);
|
||||
|
||||
ret = regmap_read(map, reg, &val);
|
||||
if (ret)
|
||||
dev_err(d->map->dev,
|
||||
"Failed to clear the interrupt status bits\n");
|
||||
}
|
||||
|
||||
d->clear_status = false;
|
||||
}
|
||||
|
||||
/*
|
||||
* If there's been a change in the mask write it back to the
|
||||
* hardware. We rely on the use of the regmap core cache to
|
||||
@@ -157,20 +174,23 @@ static void regmap_irq_sync_unlock(struct irq_data *data)
|
||||
}
|
||||
}
|
||||
|
||||
for (i = 0; i < d->chip->num_type_reg; i++) {
|
||||
if (!d->type_buf_def[i])
|
||||
continue;
|
||||
reg = d->chip->type_base +
|
||||
(i * map->reg_stride * d->type_reg_stride);
|
||||
if (d->chip->type_invert)
|
||||
ret = regmap_irq_update_bits(d, reg,
|
||||
d->type_buf_def[i], ~d->type_buf[i]);
|
||||
else
|
||||
ret = regmap_irq_update_bits(d, reg,
|
||||
d->type_buf_def[i], d->type_buf[i]);
|
||||
if (ret != 0)
|
||||
dev_err(d->map->dev, "Failed to sync type in %x\n",
|
||||
reg);
|
||||
/* Don't update the type bits if we're using mask bits for irq type. */
|
||||
if (!d->chip->type_in_mask) {
|
||||
for (i = 0; i < d->chip->num_type_reg; i++) {
|
||||
if (!d->type_buf_def[i])
|
||||
continue;
|
||||
reg = d->chip->type_base +
|
||||
(i * map->reg_stride * d->type_reg_stride);
|
||||
if (d->chip->type_invert)
|
||||
ret = regmap_irq_update_bits(d, reg,
|
||||
d->type_buf_def[i], ~d->type_buf[i]);
|
||||
else
|
||||
ret = regmap_irq_update_bits(d, reg,
|
||||
d->type_buf_def[i], d->type_buf[i]);
|
||||
if (ret != 0)
|
||||
dev_err(d->map->dev, "Failed to sync type in %x\n",
|
||||
reg);
|
||||
}
|
||||
}
|
||||
|
||||
if (d->chip->runtime_pm)
|
||||
@@ -194,8 +214,30 @@ static void regmap_irq_enable(struct irq_data *data)
|
||||
struct regmap_irq_chip_data *d = irq_data_get_irq_chip_data(data);
|
||||
struct regmap *map = d->map;
|
||||
const struct regmap_irq *irq_data = irq_to_regmap_irq(d, data->hwirq);
|
||||
unsigned int mask, type;
|
||||
|
||||
d->mask_buf[irq_data->reg_offset / map->reg_stride] &= ~irq_data->mask;
|
||||
type = irq_data->type.type_falling_val | irq_data->type.type_rising_val;
|
||||
|
||||
/*
|
||||
* The type_in_mask flag means that the underlying hardware uses
|
||||
* separate mask bits for rising and falling edge interrupts, but
|
||||
* we want to make them into a single virtual interrupt with
|
||||
* configurable edge.
|
||||
*
|
||||
* If the interrupt we're enabling defines the falling or rising
|
||||
* masks then instead of using the regular mask bits for this
|
||||
* interrupt, use the value previously written to the type buffer
|
||||
* at the corresponding offset in regmap_irq_set_type().
|
||||
*/
|
||||
if (d->chip->type_in_mask && type)
|
||||
mask = d->type_buf[irq_data->reg_offset / map->reg_stride];
|
||||
else
|
||||
mask = irq_data->mask;
|
||||
|
||||
if (d->chip->clear_on_unmask)
|
||||
d->clear_status = true;
|
||||
|
||||
d->mask_buf[irq_data->reg_offset / map->reg_stride] &= ~mask;
|
||||
}
|
||||
|
||||
static void regmap_irq_disable(struct irq_data *data)
|
||||
@@ -212,27 +254,42 @@ static int regmap_irq_set_type(struct irq_data *data, unsigned int type)
|
||||
struct regmap_irq_chip_data *d = irq_data_get_irq_chip_data(data);
|
||||
struct regmap *map = d->map;
|
||||
const struct regmap_irq *irq_data = irq_to_regmap_irq(d, data->hwirq);
|
||||
int reg = irq_data->type_reg_offset / map->reg_stride;
|
||||
int reg;
|
||||
const struct regmap_irq_type *t = &irq_data->type;
|
||||
|
||||
if (!(irq_data->type_rising_mask | irq_data->type_falling_mask))
|
||||
return 0;
|
||||
if ((t->types_supported & type) != type)
|
||||
return -ENOTSUPP;
|
||||
|
||||
d->type_buf[reg] &= ~(irq_data->type_falling_mask |
|
||||
irq_data->type_rising_mask);
|
||||
reg = t->type_reg_offset / map->reg_stride;
|
||||
|
||||
if (t->type_reg_mask)
|
||||
d->type_buf[reg] &= ~t->type_reg_mask;
|
||||
else
|
||||
d->type_buf[reg] &= ~(t->type_falling_val |
|
||||
t->type_rising_val |
|
||||
t->type_level_low_val |
|
||||
t->type_level_high_val);
|
||||
switch (type) {
|
||||
case IRQ_TYPE_EDGE_FALLING:
|
||||
d->type_buf[reg] |= irq_data->type_falling_mask;
|
||||
d->type_buf[reg] |= t->type_falling_val;
|
||||
break;
|
||||
|
||||
case IRQ_TYPE_EDGE_RISING:
|
||||
d->type_buf[reg] |= irq_data->type_rising_mask;
|
||||
d->type_buf[reg] |= t->type_rising_val;
|
||||
break;
|
||||
|
||||
case IRQ_TYPE_EDGE_BOTH:
|
||||
d->type_buf[reg] |= (irq_data->type_falling_mask |
|
||||
irq_data->type_rising_mask);
|
||||
d->type_buf[reg] |= (t->type_falling_val |
|
||||
t->type_rising_val);
|
||||
break;
|
||||
|
||||
case IRQ_TYPE_LEVEL_HIGH:
|
||||
d->type_buf[reg] |= t->type_level_high_val;
|
||||
break;
|
||||
|
||||
case IRQ_TYPE_LEVEL_LOW:
|
||||
d->type_buf[reg] |= t->type_level_low_val;
|
||||
break;
|
||||
default:
|
||||
return -EINVAL;
|
||||
}
|
||||
@@ -430,12 +487,16 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
|
||||
struct regmap_irq_chip_data *d;
|
||||
int i;
|
||||
int ret = -ENOMEM;
|
||||
int num_type_reg;
|
||||
u32 reg;
|
||||
u32 unmask_offset;
|
||||
|
||||
if (chip->num_regs <= 0)
|
||||
return -EINVAL;
|
||||
|
||||
if (chip->clear_on_unmask && (chip->ack_base || chip->use_ack))
|
||||
return -EINVAL;
|
||||
|
||||
for (i = 0; i < chip->num_irqs; i++) {
|
||||
if (chip->irqs[i].reg_offset % map->reg_stride)
|
||||
return -EINVAL;
|
||||
@@ -479,13 +540,14 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
|
||||
goto err_alloc;
|
||||
}
|
||||
|
||||
if (chip->num_type_reg) {
|
||||
d->type_buf_def = kcalloc(chip->num_type_reg,
|
||||
sizeof(unsigned int), GFP_KERNEL);
|
||||
num_type_reg = chip->type_in_mask ? chip->num_regs : chip->num_type_reg;
|
||||
if (num_type_reg) {
|
||||
d->type_buf_def = kcalloc(num_type_reg,
|
||||
sizeof(unsigned int), GFP_KERNEL);
|
||||
if (!d->type_buf_def)
|
||||
goto err_alloc;
|
||||
|
||||
d->type_buf = kcalloc(chip->num_type_reg, sizeof(unsigned int),
|
||||
d->type_buf = kcalloc(num_type_reg, sizeof(unsigned int),
|
||||
GFP_KERNEL);
|
||||
if (!d->type_buf)
|
||||
goto err_alloc;
|
||||
@@ -600,27 +662,21 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
|
||||
}
|
||||
}
|
||||
|
||||
if (chip->num_type_reg) {
|
||||
for (i = 0; i < chip->num_irqs; i++) {
|
||||
reg = chip->irqs[i].type_reg_offset / map->reg_stride;
|
||||
d->type_buf_def[reg] |= chip->irqs[i].type_rising_mask |
|
||||
chip->irqs[i].type_falling_mask;
|
||||
}
|
||||
if (chip->num_type_reg && !chip->type_in_mask) {
|
||||
for (i = 0; i < chip->num_type_reg; ++i) {
|
||||
if (!d->type_buf_def[i])
|
||||
continue;
|
||||
|
||||
reg = chip->type_base +
|
||||
(i * map->reg_stride * d->type_reg_stride);
|
||||
if (chip->type_invert)
|
||||
ret = regmap_irq_update_bits(d, reg,
|
||||
d->type_buf_def[i], 0xFF);
|
||||
else
|
||||
ret = regmap_irq_update_bits(d, reg,
|
||||
d->type_buf_def[i], 0x0);
|
||||
if (ret != 0) {
|
||||
dev_err(map->dev,
|
||||
"Failed to set type in 0x%x: %x\n",
|
||||
|
||||
ret = regmap_read(map, reg, &d->type_buf_def[i]);
|
||||
|
||||
if (d->chip->type_invert)
|
||||
d->type_buf_def[i] = ~d->type_buf_def[i];
|
||||
|
||||
if (ret) {
|
||||
dev_err(map->dev, "Failed to get type defaults at 0x%x: %d\n",
|
||||
reg, ret);
|
||||
goto err_alloc;
|
||||
}
|
||||
|
Reference in New Issue
Block a user