net: dsa: move fixed link registration helpers
The new bindings (dsa2.c) and the old bindings (legacy.c) share two helpers dsa_cpu_dsa_setup and dsa_cpu_dsa_destroy, used to register or deregister a fixed PHY if a given port has a corresponding device node. Unclutter the code by moving them into two new port.c helpers, dsa_port_fixed_link_register_of and dsa_port_fixed_link_(un)register_of. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
952c5719aa
commit
57ab1ca215
@@ -12,6 +12,8 @@
|
||||
|
||||
#include <linux/if_bridge.h>
|
||||
#include <linux/notifier.h>
|
||||
#include <linux/of_mdio.h>
|
||||
#include <linux/of_net.h>
|
||||
|
||||
#include "dsa_priv.h"
|
||||
|
||||
@@ -264,3 +266,48 @@ int dsa_port_vlan_del(struct dsa_port *dp,
|
||||
|
||||
return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_DEL, &info);
|
||||
}
|
||||
|
||||
int dsa_port_fixed_link_register_of(struct dsa_port *dp)
|
||||
{
|
||||
struct device_node *dn = dp->dn;
|
||||
struct dsa_switch *ds = dp->ds;
|
||||
struct phy_device *phydev;
|
||||
int port = dp->index;
|
||||
int mode;
|
||||
int err;
|
||||
|
||||
if (of_phy_is_fixed_link(dn)) {
|
||||
err = of_phy_register_fixed_link(dn);
|
||||
if (err) {
|
||||
dev_err(ds->dev,
|
||||
"failed to register the fixed PHY of port %d\n",
|
||||
port);
|
||||
return err;
|
||||
}
|
||||
|
||||
phydev = of_phy_find_device(dn);
|
||||
|
||||
mode = of_get_phy_mode(dn);
|
||||
if (mode < 0)
|
||||
mode = PHY_INTERFACE_MODE_NA;
|
||||
phydev->interface = mode;
|
||||
|
||||
genphy_config_init(phydev);
|
||||
genphy_read_status(phydev);
|
||||
|
||||
if (ds->ops->adjust_link)
|
||||
ds->ops->adjust_link(ds, port, phydev);
|
||||
|
||||
put_device(&phydev->mdio.dev);
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
void dsa_port_fixed_link_unregister_of(struct dsa_port *dp)
|
||||
{
|
||||
struct device_node *dn = dp->dn;
|
||||
|
||||
if (of_phy_is_fixed_link(dn))
|
||||
of_phy_deregister_fixed_link(dn);
|
||||
}
|
||||
|
Reference in New Issue
Block a user