Merge branch 'bjorn-notify' into release
Conflicts: drivers/platform/x86/eeepc-laptop.c Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
@@ -207,13 +207,17 @@ MODULE_DEVICE_TABLE(acpi, asus_device_ids);
|
||||
|
||||
static int asus_hotk_add(struct acpi_device *device);
|
||||
static int asus_hotk_remove(struct acpi_device *device, int type);
|
||||
static void asus_hotk_notify(struct acpi_device *device, u32 event);
|
||||
|
||||
static struct acpi_driver asus_hotk_driver = {
|
||||
.name = ASUS_HOTK_NAME,
|
||||
.class = ASUS_HOTK_CLASS,
|
||||
.ids = asus_device_ids,
|
||||
.flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
|
||||
.ops = {
|
||||
.add = asus_hotk_add,
|
||||
.remove = asus_hotk_remove,
|
||||
.notify = asus_hotk_notify,
|
||||
},
|
||||
};
|
||||
|
||||
@@ -812,7 +816,7 @@ static int asus_setkeycode(struct input_dev *dev, int scancode, int keycode)
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
static void asus_hotk_notify(acpi_handle handle, u32 event, void *data)
|
||||
static void asus_hotk_notify(struct acpi_device *device, u32 event)
|
||||
{
|
||||
static struct key_entry *key;
|
||||
u16 count;
|
||||
@@ -1124,7 +1128,6 @@ static int asus_hotk_found;
|
||||
|
||||
static int asus_hotk_add(struct acpi_device *device)
|
||||
{
|
||||
acpi_status status = AE_OK;
|
||||
int result;
|
||||
|
||||
if (!device)
|
||||
@@ -1149,15 +1152,6 @@ static int asus_hotk_add(struct acpi_device *device)
|
||||
|
||||
asus_hotk_add_fs();
|
||||
|
||||
/*
|
||||
* We install the handler, it will receive the hotk in parameter, so, we
|
||||
* could add other data to the hotk struct
|
||||
*/
|
||||
status = acpi_install_notify_handler(hotk->handle, ACPI_ALL_NOTIFY,
|
||||
asus_hotk_notify, hotk);
|
||||
if (ACPI_FAILURE(status))
|
||||
printk(ASUS_ERR "Error installing notify handler\n");
|
||||
|
||||
asus_hotk_found = 1;
|
||||
|
||||
/* WLED and BLED are on by default */
|
||||
@@ -1198,16 +1192,9 @@ end:
|
||||
|
||||
static int asus_hotk_remove(struct acpi_device *device, int type)
|
||||
{
|
||||
acpi_status status = 0;
|
||||
|
||||
if (!device || !acpi_driver_data(device))
|
||||
return -EINVAL;
|
||||
|
||||
status = acpi_remove_notify_handler(hotk->handle, ACPI_ALL_NOTIFY,
|
||||
asus_hotk_notify);
|
||||
if (ACPI_FAILURE(status))
|
||||
printk(ASUS_ERR "Error removing notify handler\n");
|
||||
|
||||
kfree(hotk->name);
|
||||
kfree(hotk);
|
||||
|
||||
|
@@ -455,6 +455,8 @@ static struct asus_hotk *hotk;
|
||||
*/
|
||||
static int asus_hotk_add(struct acpi_device *device);
|
||||
static int asus_hotk_remove(struct acpi_device *device, int type);
|
||||
static void asus_hotk_notify(struct acpi_device *device, u32 event);
|
||||
|
||||
static const struct acpi_device_id asus_device_ids[] = {
|
||||
{"ATK0100", 0},
|
||||
{"", 0},
|
||||
@@ -465,9 +467,11 @@ static struct acpi_driver asus_hotk_driver = {
|
||||
.name = "asus_acpi",
|
||||
.class = ACPI_HOTK_CLASS,
|
||||
.ids = asus_device_ids,
|
||||
.flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
|
||||
.ops = {
|
||||
.add = asus_hotk_add,
|
||||
.remove = asus_hotk_remove,
|
||||
.notify = asus_hotk_notify,
|
||||
},
|
||||
};
|
||||
|
||||
@@ -1101,12 +1105,20 @@ static int asus_hotk_remove_fs(struct acpi_device *device)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void asus_hotk_notify(acpi_handle handle, u32 event, void *data)
|
||||
static void asus_hotk_notify(struct acpi_device *device, u32 event)
|
||||
{
|
||||
/* TODO Find a better way to handle events count. */
|
||||
if (!hotk)
|
||||
return;
|
||||
|
||||
/*
|
||||
* The BIOS *should* be sending us device events, but apparently
|
||||
* Asus uses system events instead, so just ignore any device
|
||||
* events we get.
|
||||
*/
|
||||
if (event > ACPI_MAX_SYS_NOTIFY)
|
||||
return;
|
||||
|
||||
if ((event & ~((u32) BR_UP)) < 16)
|
||||
hotk->brightness = (event & ~((u32) BR_UP));
|
||||
else if ((event & ~((u32) BR_DOWN)) < 16)
|
||||
@@ -1346,15 +1358,6 @@ static int asus_hotk_add(struct acpi_device *device)
|
||||
if (result)
|
||||
goto end;
|
||||
|
||||
/*
|
||||
* We install the handler, it will receive the hotk in parameter, so, we
|
||||
* could add other data to the hotk struct
|
||||
*/
|
||||
status = acpi_install_notify_handler(hotk->handle, ACPI_SYSTEM_NOTIFY,
|
||||
asus_hotk_notify, hotk);
|
||||
if (ACPI_FAILURE(status))
|
||||
printk(KERN_ERR " Error installing notify handler\n");
|
||||
|
||||
/* For laptops without GPLV: init the hotk->brightness value */
|
||||
if ((!hotk->methods->brightness_get)
|
||||
&& (!hotk->methods->brightness_status)
|
||||
@@ -1389,16 +1392,9 @@ end:
|
||||
|
||||
static int asus_hotk_remove(struct acpi_device *device, int type)
|
||||
{
|
||||
acpi_status status = 0;
|
||||
|
||||
if (!device || !acpi_driver_data(device))
|
||||
return -EINVAL;
|
||||
|
||||
status = acpi_remove_notify_handler(hotk->handle, ACPI_SYSTEM_NOTIFY,
|
||||
asus_hotk_notify);
|
||||
if (ACPI_FAILURE(status))
|
||||
printk(KERN_ERR "Asus ACPI: Error removing notify handler\n");
|
||||
|
||||
asus_hotk_remove_fs(device);
|
||||
|
||||
kfree(hotk);
|
||||
|
@@ -181,6 +181,7 @@ static struct key_entry eeepc_keymap[] = {
|
||||
static int eeepc_hotk_add(struct acpi_device *device);
|
||||
static int eeepc_hotk_remove(struct acpi_device *device, int type);
|
||||
static int eeepc_hotk_resume(struct acpi_device *device);
|
||||
static void eeepc_hotk_notify(struct acpi_device *device, u32 event);
|
||||
|
||||
static const struct acpi_device_id eeepc_device_ids[] = {
|
||||
{EEEPC_HOTK_HID, 0},
|
||||
@@ -192,10 +193,12 @@ static struct acpi_driver eeepc_hotk_driver = {
|
||||
.name = EEEPC_HOTK_NAME,
|
||||
.class = EEEPC_HOTK_CLASS,
|
||||
.ids = eeepc_device_ids,
|
||||
.flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
|
||||
.ops = {
|
||||
.add = eeepc_hotk_add,
|
||||
.remove = eeepc_hotk_remove,
|
||||
.resume = eeepc_hotk_resume,
|
||||
.notify = eeepc_hotk_notify,
|
||||
},
|
||||
};
|
||||
|
||||
@@ -558,7 +561,7 @@ static void eeepc_rfkill_notify(acpi_handle handle, u32 event, void *data)
|
||||
eeepc_rfkill_hotplug();
|
||||
}
|
||||
|
||||
static void eeepc_hotk_notify(acpi_handle handle, u32 event, void *data)
|
||||
static void eeepc_hotk_notify(struct acpi_device *device, u32 event)
|
||||
{
|
||||
static struct key_entry *key;
|
||||
u16 count;
|
||||
@@ -566,6 +569,8 @@ static void eeepc_hotk_notify(acpi_handle handle, u32 event, void *data)
|
||||
|
||||
if (!ehotk)
|
||||
return;
|
||||
if (event > ACPI_MAX_SYS_NOTIFY)
|
||||
return;
|
||||
if (event >= NOTIFY_BRN_MIN && event <= NOTIFY_BRN_MAX)
|
||||
brn = notify_brn();
|
||||
count = ehotk->event_count[event % 128]++;
|
||||
@@ -646,7 +651,6 @@ static void eeepc_unregister_rfkill_notifier(char *node)
|
||||
|
||||
static int eeepc_hotk_add(struct acpi_device *device)
|
||||
{
|
||||
acpi_status status = AE_OK;
|
||||
int result;
|
||||
|
||||
if (!device)
|
||||
@@ -664,10 +668,6 @@ static int eeepc_hotk_add(struct acpi_device *device)
|
||||
result = eeepc_hotk_check();
|
||||
if (result)
|
||||
goto ehotk_fail;
|
||||
status = acpi_install_notify_handler(ehotk->handle, ACPI_SYSTEM_NOTIFY,
|
||||
eeepc_hotk_notify, ehotk);
|
||||
if (ACPI_FAILURE(status))
|
||||
printk(EEEPC_ERR "Error installing notify handler\n");
|
||||
|
||||
eeepc_register_rfkill_notifier("\\_SB.PCI0.P0P6");
|
||||
eeepc_register_rfkill_notifier("\\_SB.PCI0.P0P7");
|
||||
@@ -725,14 +725,8 @@ static int eeepc_hotk_add(struct acpi_device *device)
|
||||
|
||||
static int eeepc_hotk_remove(struct acpi_device *device, int type)
|
||||
{
|
||||
acpi_status status = 0;
|
||||
|
||||
if (!device || !acpi_driver_data(device))
|
||||
return -EINVAL;
|
||||
status = acpi_remove_notify_handler(ehotk->handle, ACPI_SYSTEM_NOTIFY,
|
||||
eeepc_hotk_notify);
|
||||
if (ACPI_FAILURE(status))
|
||||
printk(EEEPC_ERR "Error removing notify handler\n");
|
||||
|
||||
eeepc_unregister_rfkill_notifier("\\_SB.PCI0.P0P6");
|
||||
eeepc_unregister_rfkill_notifier("\\_SB.PCI0.P0P7");
|
||||
|
Reference in New Issue
Block a user