powerpc/mm: properly set PAGE_KERNEL flags in ioremap()
Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags in PPC32 ioremap() derived functions. Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:

committad av
Michael Ellerman

förälder
aa91796ec4
incheckning
56f3c1413f
@@ -76,32 +76,36 @@ pgtable_t pte_alloc_one(struct mm_struct *mm, unsigned long address)
|
||||
void __iomem *
|
||||
ioremap(phys_addr_t addr, unsigned long size)
|
||||
{
|
||||
return __ioremap_caller(addr, size, _PAGE_NO_CACHE | _PAGE_GUARDED,
|
||||
__builtin_return_address(0));
|
||||
unsigned long flags = pgprot_val(pgprot_noncached(PAGE_KERNEL));
|
||||
|
||||
return __ioremap_caller(addr, size, flags, __builtin_return_address(0));
|
||||
}
|
||||
EXPORT_SYMBOL(ioremap);
|
||||
|
||||
void __iomem *
|
||||
ioremap_wc(phys_addr_t addr, unsigned long size)
|
||||
{
|
||||
return __ioremap_caller(addr, size, _PAGE_NO_CACHE,
|
||||
__builtin_return_address(0));
|
||||
unsigned long flags = pgprot_val(pgprot_noncached_wc(PAGE_KERNEL));
|
||||
|
||||
return __ioremap_caller(addr, size, flags, __builtin_return_address(0));
|
||||
}
|
||||
EXPORT_SYMBOL(ioremap_wc);
|
||||
|
||||
void __iomem *
|
||||
ioremap_wt(phys_addr_t addr, unsigned long size)
|
||||
{
|
||||
return __ioremap_caller(addr, size, _PAGE_WRITETHRU,
|
||||
__builtin_return_address(0));
|
||||
unsigned long flags = pgprot_val(pgprot_cached_wthru(PAGE_KERNEL));
|
||||
|
||||
return __ioremap_caller(addr, size, flags, __builtin_return_address(0));
|
||||
}
|
||||
EXPORT_SYMBOL(ioremap_wt);
|
||||
|
||||
void __iomem *
|
||||
ioremap_coherent(phys_addr_t addr, unsigned long size)
|
||||
{
|
||||
return __ioremap_caller(addr, size, _PAGE_COHERENT,
|
||||
__builtin_return_address(0));
|
||||
unsigned long flags = pgprot_val(pgprot_cached(PAGE_KERNEL));
|
||||
|
||||
return __ioremap_caller(addr, size, flags, __builtin_return_address(0));
|
||||
}
|
||||
EXPORT_SYMBOL(ioremap_coherent);
|
||||
|
||||
@@ -134,14 +138,6 @@ __ioremap_caller(phys_addr_t addr, unsigned long size, unsigned long flags,
|
||||
phys_addr_t p;
|
||||
int err;
|
||||
|
||||
/* Make sure we have the base flags */
|
||||
if ((flags & _PAGE_PRESENT) == 0)
|
||||
flags |= pgprot_val(PAGE_KERNEL);
|
||||
|
||||
/* Non-cacheable page cannot be coherent */
|
||||
if (flags & _PAGE_NO_CACHE)
|
||||
flags &= ~_PAGE_COHERENT;
|
||||
|
||||
/*
|
||||
* Choose an address to map it to.
|
||||
* Once the vmalloc system is running, we use it.
|
||||
|
@@ -118,10 +118,6 @@ void __iomem * __ioremap_at(phys_addr_t pa, void *ea, unsigned long size,
|
||||
{
|
||||
unsigned long i;
|
||||
|
||||
/* Make sure we have the base flags */
|
||||
if ((flags & _PAGE_PRESENT) == 0)
|
||||
flags |= pgprot_val(PAGE_KERNEL);
|
||||
|
||||
/* We don't support the 4K PFN hack with ioremap */
|
||||
if (flags & H_PAGE_4K_PFN)
|
||||
return NULL;
|
||||
@@ -204,7 +200,7 @@ void __iomem * __ioremap(phys_addr_t addr, unsigned long size,
|
||||
|
||||
void __iomem * ioremap(phys_addr_t addr, unsigned long size)
|
||||
{
|
||||
unsigned long flags = pgprot_val(pgprot_noncached(__pgprot(0)));
|
||||
unsigned long flags = pgprot_val(pgprot_noncached(PAGE_KERNEL));
|
||||
void *caller = __builtin_return_address(0);
|
||||
|
||||
if (ppc_md.ioremap)
|
||||
@@ -214,7 +210,7 @@ void __iomem * ioremap(phys_addr_t addr, unsigned long size)
|
||||
|
||||
void __iomem * ioremap_wc(phys_addr_t addr, unsigned long size)
|
||||
{
|
||||
unsigned long flags = pgprot_val(pgprot_noncached_wc(__pgprot(0)));
|
||||
unsigned long flags = pgprot_val(pgprot_noncached_wc(PAGE_KERNEL));
|
||||
void *caller = __builtin_return_address(0);
|
||||
|
||||
if (ppc_md.ioremap)
|
||||
@@ -224,7 +220,7 @@ void __iomem * ioremap_wc(phys_addr_t addr, unsigned long size)
|
||||
|
||||
void __iomem *ioremap_coherent(phys_addr_t addr, unsigned long size)
|
||||
{
|
||||
unsigned long flags = pgprot_val(pgprot_cached(__pgprot(0)));
|
||||
unsigned long flags = pgprot_val(pgprot_cached(PAGE_KERNEL));
|
||||
void *caller = __builtin_return_address(0);
|
||||
|
||||
if (ppc_md.ioremap)
|
||||
|
Referens i nytt ärende
Block a user