fddi: skfp: Use more common logging styles
Several macros use non-standard styles where format and arguments are not verified. Convert these to a more typical fmt, ##__VA_ARGS__ use so format and arguments match as appropriate. Miscellanea: o Fix format and argument mismatches o Realign and reindent misindented block o Strip newlines from formats and add to macro defines o Coalesce a few consecutive logging uses to more simple single uses Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

کامیت شده توسط
David S. Miller

والد
5dbc653093
کامیت
5671e8c19c
@@ -70,7 +70,6 @@ static const char ID_sccs[] = "@(#)rmt.c 2.13 99/07/02 (C) SK " ;
|
||||
#define RM6_DIRECTED 6 /* sending directed beacons */
|
||||
#define RM7_TRACE 7 /* trace initiated */
|
||||
|
||||
#ifdef DEBUG
|
||||
/*
|
||||
* symbolic state names
|
||||
*/
|
||||
@@ -91,7 +90,6 @@ static const char * const rmt_events[] = {
|
||||
"RM_TIMEOUT_ANNOUNCE","RM_TIMEOUT_T_DIRECT",
|
||||
"RM_TIMEOUT_D_MAX","RM_TIMEOUT_POLL","RM_TX_STATE_CHANGE"
|
||||
} ;
|
||||
#endif
|
||||
|
||||
/*
|
||||
* Globals
|
||||
@@ -149,10 +147,10 @@ void rmt(struct s_smc *smc, int event)
|
||||
int state ;
|
||||
|
||||
do {
|
||||
DB_RMT("RMT : state %s%s",
|
||||
(smc->mib.m[MAC0].fddiMACRMTState & AFLAG) ? "ACTIONS " : "",
|
||||
rmt_states[smc->mib.m[MAC0].fddiMACRMTState & ~AFLAG]) ;
|
||||
DB_RMT(" event %s\n",rmt_events[event],0) ;
|
||||
DB_RMT("RMT : state %s%s event %s",
|
||||
smc->mib.m[MAC0].fddiMACRMTState & AFLAG ? "ACTIONS " : "",
|
||||
rmt_states[smc->mib.m[MAC0].fddiMACRMTState & ~AFLAG],
|
||||
rmt_events[event]);
|
||||
state = smc->mib.m[MAC0].fddiMACRMTState ;
|
||||
rmt_fsm(smc,event) ;
|
||||
event = 0 ;
|
||||
@@ -191,7 +189,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
smc->r.loop_avail = FALSE ;
|
||||
smc->r.sm_ma_avail = FALSE ;
|
||||
smc->r.no_flag = TRUE ;
|
||||
DB_RMTN(1,"RMT : ISOLATED\n",0,0) ;
|
||||
DB_RMTN(1, "RMT : ISOLATED");
|
||||
ACTIONS_DONE() ;
|
||||
break ;
|
||||
case RM0_ISOLATED :
|
||||
@@ -213,7 +211,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
stop_rmt_timer1(smc) ;
|
||||
stop_rmt_timer2(smc) ;
|
||||
sm_ma_control(smc,MA_BEACON) ;
|
||||
DB_RMTN(1,"RMT : RING DOWN\n",0,0) ;
|
||||
DB_RMTN(1, "RMT : RING DOWN");
|
||||
RS_SET(smc,RS_NORINGOP) ;
|
||||
smc->r.sm_ma_avail = FALSE ;
|
||||
rmt_indication(smc,0) ;
|
||||
@@ -248,7 +246,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
else
|
||||
smc->mib.m[MAC0].fddiMACMA_UnitdataAvailable = FALSE ;
|
||||
}
|
||||
DB_RMTN(1,"RMT : RING UP\n",0,0) ;
|
||||
DB_RMTN(1, "RMT : RING UP");
|
||||
RS_CLEAR(smc,RS_NORINGOP) ;
|
||||
RS_SET(smc,RS_RINGOPCHANGE) ;
|
||||
rmt_indication(smc,1) ;
|
||||
@@ -285,7 +283,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
start_rmt_timer1(smc,smc->s.rmt_t_stuck,RM_TIMEOUT_T_STUCK) ;
|
||||
start_rmt_timer2(smc,smc->s.rmt_t_poll,RM_TIMEOUT_POLL) ;
|
||||
sm_mac_check_beacon_claim(smc) ;
|
||||
DB_RMTN(1,"RMT : RM3_DETECT\n",0,0) ;
|
||||
DB_RMTN(1, "RMT : RM3_DETECT");
|
||||
ACTIONS_DONE() ;
|
||||
break ;
|
||||
case RM3_DETECT :
|
||||
@@ -327,7 +325,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
* trace !
|
||||
*/
|
||||
if ((tx = sm_mac_get_tx_state(smc)) == 4 || tx == 5) {
|
||||
DB_RMTN(2,"RMT : DETECT && TRT_EXPIRED && T4/T5\n",0,0);
|
||||
DB_RMTN(2, "RMT : DETECT && TRT_EXPIRED && T4/T5");
|
||||
smc->r.bn_flag = TRUE ;
|
||||
/*
|
||||
* If one of the upstream stations beaconed
|
||||
@@ -344,9 +342,8 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
* must be cleared in order to get in this condition.
|
||||
*/
|
||||
|
||||
DB_RMTN(2,
|
||||
"RMT : sm_mac_get_tx_state() = %d (bn_flag = %d)\n",
|
||||
tx,smc->r.bn_flag) ;
|
||||
DB_RMTN(2, "RMT : sm_mac_get_tx_state() = %d (bn_flag = %d)",
|
||||
tx, smc->r.bn_flag);
|
||||
}
|
||||
/*RM34a*/
|
||||
else if (cmd == RM_MY_CLAIM && smc->r.timer0_exp) {
|
||||
@@ -378,7 +375,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
start_rmt_timer1(smc,smc->s.rmt_t_stuck,RM_TIMEOUT_T_STUCK) ;
|
||||
start_rmt_timer2(smc,smc->s.rmt_t_poll,RM_TIMEOUT_POLL) ;
|
||||
sm_mac_check_beacon_claim(smc) ;
|
||||
DB_RMTN(1,"RMT : RM4_NON_OP_DUP\n",0,0) ;
|
||||
DB_RMTN(1, "RMT : RM4_NON_OP_DUP");
|
||||
ACTIONS_DONE() ;
|
||||
break ;
|
||||
case RM4_NON_OP_DUP :
|
||||
@@ -406,7 +403,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
* trace !
|
||||
*/
|
||||
if ((tx = sm_mac_get_tx_state(smc)) == 4 || tx == 5) {
|
||||
DB_RMTN(2,"RMT : NOPDUP && TRT_EXPIRED && T4/T5\n",0,0);
|
||||
DB_RMTN(2, "RMT : NOPDUP && TRT_EXPIRED && T4/T5");
|
||||
smc->r.bn_flag = TRUE ;
|
||||
/*
|
||||
* If one of the upstream stations beaconed
|
||||
@@ -423,9 +420,8 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
* must be cleared in order to get in this condition.
|
||||
*/
|
||||
|
||||
DB_RMTN(2,
|
||||
"RMT : sm_mac_get_tx_state() = %d (bn_flag = %d)\n",
|
||||
tx,smc->r.bn_flag) ;
|
||||
DB_RMTN(2, "RMT : sm_mac_get_tx_state() = %d (bn_flag = %d)",
|
||||
tx, smc->r.bn_flag);
|
||||
}
|
||||
/*RM44c*/
|
||||
else if (cmd == RM_TIMEOUT_ANNOUNCE && !smc->r.bn_flag) {
|
||||
@@ -448,7 +444,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
stop_rmt_timer0(smc) ;
|
||||
stop_rmt_timer1(smc) ;
|
||||
stop_rmt_timer2(smc) ;
|
||||
DB_RMTN(1,"RMT : RM5_RING_OP_DUP\n",0,0) ;
|
||||
DB_RMTN(1, "RMT : RM5_RING_OP_DUP");
|
||||
ACTIONS_DONE() ;
|
||||
break;
|
||||
case RM5_RING_OP_DUP :
|
||||
@@ -472,7 +468,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
start_rmt_timer2(smc,smc->s.rmt_t_poll,RM_TIMEOUT_POLL) ;
|
||||
sm_ma_control(smc,MA_DIRECTED) ;
|
||||
RS_SET(smc,RS_BEACON) ;
|
||||
DB_RMTN(1,"RMT : RM6_DIRECTED\n",0,0) ;
|
||||
DB_RMTN(1, "RMT : RM6_DIRECTED");
|
||||
ACTIONS_DONE() ;
|
||||
break ;
|
||||
case RM6_DIRECTED :
|
||||
@@ -515,7 +511,7 @@ static void rmt_fsm(struct s_smc *smc, int cmd)
|
||||
stop_rmt_timer2(smc) ;
|
||||
smc->e.trace_prop |= ENTITY_BIT(ENTITY_MAC) ;
|
||||
queue_event(smc,EVENT_ECM,EC_TRACE_PROP) ;
|
||||
DB_RMTN(1,"RMT : RM7_TRACE\n",0,0) ;
|
||||
DB_RMTN(1, "RMT : RM7_TRACE");
|
||||
ACTIONS_DONE() ;
|
||||
break ;
|
||||
case RM7_TRACE :
|
||||
|
مرجع در شماره جدید
Block a user