net, xfrm: convert sec_path.refcnt from atomic_t to refcount_t
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: David Windsor <dwindsor@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
850a6212c6
commit
55eabed60a
@@ -116,7 +116,7 @@ struct sec_path *secpath_dup(struct sec_path *src)
|
||||
for (i = 0; i < sp->len; i++)
|
||||
xfrm_state_hold(sp->xvec[i]);
|
||||
}
|
||||
atomic_set(&sp->refcnt, 1);
|
||||
refcount_set(&sp->refcnt, 1);
|
||||
return sp;
|
||||
}
|
||||
EXPORT_SYMBOL(secpath_dup);
|
||||
@@ -126,7 +126,7 @@ int secpath_set(struct sk_buff *skb)
|
||||
struct sec_path *sp;
|
||||
|
||||
/* Allocate new secpath or COW existing one. */
|
||||
if (!skb->sp || atomic_read(&skb->sp->refcnt) != 1) {
|
||||
if (!skb->sp || refcount_read(&skb->sp->refcnt) != 1) {
|
||||
sp = secpath_dup(skb->sp);
|
||||
if (!sp)
|
||||
return -ENOMEM;
|
||||
|
Reference in New Issue
Block a user