i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls
There is simply no reason to be manually setting the private driver data to NULL in the remove/fail to probe cases. This is just extra cruft code that can be removed. A few notes: * Nothing relies on drvdata being set to NULL. * The __device_release_driver() function eventually calls dev_set_drvdata(dev, NULL) anyway, so there's no need to do it twice. * I verified that there were no cases where xxx_get_drvdata() was being called in these drivers and checking for / relying on the NULL return value. This could be cleaned up kernel-wide but for now just take the baby step and remove from the i2c subsystem. Reported-by: Wolfram Sang <wsa@the-dreams.de> Reported-by: Stephen Warren <swarren@wwwdotorg.org> Signed-off-by: Doug Anderson <dianders@chromium.org> Reviewed-by: Jean Delvare <khali@linux-fr.org> Acked-by: Peter Korsgaard <jacmet@sunsite.dk> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Reviewed-by: Marek Vasut <marex@denx.de> Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>
This commit is contained in:

committato da
Wolfram Sang

parent
0a6d224679
commit
55827f4aa6
@@ -1069,7 +1069,6 @@ static int intel_mid_i2c_probe(struct pci_dev *dev,
|
||||
fail3:
|
||||
free_irq(dev->irq, mrst);
|
||||
fail2:
|
||||
pci_set_drvdata(dev, NULL);
|
||||
kfree(mrst);
|
||||
fail1:
|
||||
iounmap(base);
|
||||
@@ -1087,7 +1086,6 @@ static void intel_mid_i2c_remove(struct pci_dev *dev)
|
||||
dev_err(&dev->dev, "Failed to delete i2c adapter");
|
||||
|
||||
free_irq(dev->irq, mrst);
|
||||
pci_set_drvdata(dev, NULL);
|
||||
iounmap(mrst->base);
|
||||
kfree(mrst);
|
||||
pci_release_region(dev, 0);
|
||||
|
Fai riferimento in un nuovo problema
Block a user