net: phy: Make phy_ethtool_ksettings_get return void
Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
d980b8d1fc
commit
5514174fe9
@@ -1836,7 +1836,9 @@ static int b44_get_link_ksettings(struct net_device *dev,
|
||||
|
||||
if (bp->flags & B44_FLAG_EXTERNAL_PHY) {
|
||||
BUG_ON(!dev->phydev);
|
||||
return phy_ethtool_ksettings_get(dev->phydev, cmd);
|
||||
phy_ethtool_ksettings_get(dev->phydev, cmd);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
supported = (SUPPORTED_Autoneg);
|
||||
|
@@ -1453,7 +1453,10 @@ static int bcm_enet_get_link_ksettings(struct net_device *dev,
|
||||
if (priv->has_phy) {
|
||||
if (!dev->phydev)
|
||||
return -ENODEV;
|
||||
return phy_ethtool_ksettings_get(dev->phydev, cmd);
|
||||
|
||||
phy_ethtool_ksettings_get(dev->phydev, cmd);
|
||||
|
||||
return 0;
|
||||
} else {
|
||||
cmd->base.autoneg = 0;
|
||||
cmd->base.speed = (priv->force_speed_100) ?
|
||||
|
@@ -477,7 +477,9 @@ static int bcmgenet_get_link_ksettings(struct net_device *dev,
|
||||
if (!priv->phydev)
|
||||
return -ENODEV;
|
||||
|
||||
return phy_ethtool_ksettings_get(priv->phydev, cmd);
|
||||
phy_ethtool_ksettings_get(priv->phydev, cmd);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int bcmgenet_set_link_ksettings(struct net_device *dev,
|
||||
|
@@ -12097,7 +12097,9 @@ static int tg3_get_link_ksettings(struct net_device *dev,
|
||||
if (!(tp->phy_flags & TG3_PHYFLG_IS_CONNECTED))
|
||||
return -EAGAIN;
|
||||
phydev = mdiobus_get_phy(tp->mdio_bus, tp->phy_addr);
|
||||
return phy_ethtool_ksettings_get(phydev, cmd);
|
||||
phy_ethtool_ksettings_get(phydev, cmd);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
supported = (SUPPORTED_Autoneg);
|
||||
|
Reference in New Issue
Block a user