ASoC: rsnd: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ local idexpression n; expression e,e1; identifier l; @@ for_each_child_of_node(e1,n) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? goto l; ) ... } ... l: ... when != n // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Mark Brown <broonie@kernel.org>
此提交包含在:
@@ -380,13 +380,16 @@ int rsnd_dvc_probe(struct rsnd_priv *priv)
|
||||
clk = devm_clk_get(dev, name);
|
||||
if (IS_ERR(clk)) {
|
||||
ret = PTR_ERR(clk);
|
||||
of_node_put(np);
|
||||
goto rsnd_dvc_probe_done;
|
||||
}
|
||||
|
||||
ret = rsnd_mod_init(priv, rsnd_mod_get(dvc), &rsnd_dvc_ops,
|
||||
clk, rsnd_mod_get_status, RSND_MOD_DVC, i);
|
||||
if (ret)
|
||||
if (ret) {
|
||||
of_node_put(np);
|
||||
goto rsnd_dvc_probe_done;
|
||||
}
|
||||
|
||||
i++;
|
||||
}
|
||||
|
新增問題並參考
封鎖使用者