ide: cleanup ->prep_rq calling convention
The return value is just used as a binary yes/no decision, so switch it to a bool instead of the old BLKPREP_* values returned as an int. Also clean up a few related comments. Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Este commit está contenido en:

cometido por
Jens Axboe

padre
9d037ad707
commit
535ac5d3fe
@@ -326,7 +326,7 @@ static ide_startstop_t start_request (ide_drive_t *drive, struct request *rq)
|
||||
goto kill_rq;
|
||||
}
|
||||
|
||||
if (drive->prep_rq && drive->prep_rq(drive, rq))
|
||||
if (drive->prep_rq && !drive->prep_rq(drive, rq))
|
||||
return ide_stopped;
|
||||
|
||||
if (ata_pm_request(rq))
|
||||
@@ -508,7 +508,7 @@ repeat:
|
||||
|
||||
/*
|
||||
* we know that the queue isn't empty, but this can happen
|
||||
* if the q->prep_rq_fn() decides to kill a request
|
||||
* if ->prep_rq() decides to kill a request
|
||||
*/
|
||||
if (!rq) {
|
||||
rq = bd->rq;
|
||||
|
Referencia en una nueva incidencia
Block a user