hwmon: Clean up detect functions
As kind is now hard-coded to -1, there is room for code clean-ups. Signed-off-by: Jean Delvare <khali@linux-fr.org> Acked-by: Corentin Labbe <corentin.labbe@geomatys.fr> Cc: "Mark M. Hoffman" <mhoffman@lightlink.com> Cc: Juerg Haefliger <juergh@gmail.com> Cc: Riku Voipio <riku.voipio@iki.fi> Acked-by: "Hans J. Koch" <hjk@linutronix.de> Cc: Rudolf Marek <r.marek@assembler.cz>
Esse commit está contido em:
@@ -1906,27 +1906,22 @@ static int adt7462_detect(struct i2c_client *client, int kind,
|
||||
struct i2c_board_info *info)
|
||||
{
|
||||
struct i2c_adapter *adapter = client->adapter;
|
||||
int vendor, device, revision;
|
||||
|
||||
if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
|
||||
return -ENODEV;
|
||||
|
||||
if (kind <= 0) {
|
||||
int vendor, device, revision;
|
||||
vendor = i2c_smbus_read_byte_data(client, ADT7462_REG_VENDOR);
|
||||
if (vendor != ADT7462_VENDOR)
|
||||
return -ENODEV;
|
||||
|
||||
vendor = i2c_smbus_read_byte_data(client, ADT7462_REG_VENDOR);
|
||||
if (vendor != ADT7462_VENDOR)
|
||||
return -ENODEV;
|
||||
device = i2c_smbus_read_byte_data(client, ADT7462_REG_DEVICE);
|
||||
if (device != ADT7462_DEVICE)
|
||||
return -ENODEV;
|
||||
|
||||
device = i2c_smbus_read_byte_data(client, ADT7462_REG_DEVICE);
|
||||
if (device != ADT7462_DEVICE)
|
||||
return -ENODEV;
|
||||
|
||||
revision = i2c_smbus_read_byte_data(client,
|
||||
ADT7462_REG_REVISION);
|
||||
if (revision != ADT7462_REVISION)
|
||||
return -ENODEV;
|
||||
} else
|
||||
dev_dbg(&adapter->dev, "detection forced\n");
|
||||
revision = i2c_smbus_read_byte_data(client, ADT7462_REG_REVISION);
|
||||
if (revision != ADT7462_REVISION)
|
||||
return -ENODEV;
|
||||
|
||||
strlcpy(info->type, "adt7462", I2C_NAME_SIZE);
|
||||
|
||||
|
Referência em uma nova issue
Block a user