xen: assume XENFEAT_gnttab_map_avail_bits being set for pv guests
[ Upstream commit 30dcc56bba911db561c35d4131baf983a41023f8 ] XENFEAT_gnttab_map_avail_bits is always set in Xen 4.0 and newer. Remove coding assuming it might be zero. Signed-off-by: Juergen Gross <jgross@suse.com> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Link: https://lore.kernel.org/r/20210730071804.4302-4-jgross@suse.com Signed-off-by: Juergen Gross <jgross@suse.com> Stable-dep-of: 5c13a4a0291b ("xen/gntdev: Accommodate VMA splitting") Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
ea82edad0a
commit
5232411f37
@@ -289,20 +289,13 @@ static int find_grant_ptes(pte_t *pte, unsigned long addr, void *data)
|
|||||||
{
|
{
|
||||||
struct gntdev_grant_map *map = data;
|
struct gntdev_grant_map *map = data;
|
||||||
unsigned int pgnr = (addr - map->vma->vm_start) >> PAGE_SHIFT;
|
unsigned int pgnr = (addr - map->vma->vm_start) >> PAGE_SHIFT;
|
||||||
int flags = map->flags | GNTMAP_application_map | GNTMAP_contains_pte;
|
int flags = map->flags | GNTMAP_application_map | GNTMAP_contains_pte |
|
||||||
|
(1 << _GNTMAP_guest_avail0);
|
||||||
u64 pte_maddr;
|
u64 pte_maddr;
|
||||||
|
|
||||||
BUG_ON(pgnr >= map->count);
|
BUG_ON(pgnr >= map->count);
|
||||||
pte_maddr = arbitrary_virt_to_machine(pte).maddr;
|
pte_maddr = arbitrary_virt_to_machine(pte).maddr;
|
||||||
|
|
||||||
/*
|
|
||||||
* Set the PTE as special to force get_user_pages_fast() fall
|
|
||||||
* back to the slow path. If this is not supported as part of
|
|
||||||
* the grant map, it will be done afterwards.
|
|
||||||
*/
|
|
||||||
if (xen_feature(XENFEAT_gnttab_map_avail_bits))
|
|
||||||
flags |= (1 << _GNTMAP_guest_avail0);
|
|
||||||
|
|
||||||
gnttab_set_map_op(&map->map_ops[pgnr], pte_maddr, flags,
|
gnttab_set_map_op(&map->map_ops[pgnr], pte_maddr, flags,
|
||||||
map->grants[pgnr].ref,
|
map->grants[pgnr].ref,
|
||||||
map->grants[pgnr].domid);
|
map->grants[pgnr].domid);
|
||||||
@@ -311,14 +304,6 @@ static int find_grant_ptes(pte_t *pte, unsigned long addr, void *data)
|
|||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
#ifdef CONFIG_X86
|
|
||||||
static int set_grant_ptes_as_special(pte_t *pte, unsigned long addr, void *data)
|
|
||||||
{
|
|
||||||
set_pte_at(current->mm, addr, pte, pte_mkspecial(*pte));
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
#endif
|
|
||||||
|
|
||||||
int gntdev_map_grant_pages(struct gntdev_grant_map *map)
|
int gntdev_map_grant_pages(struct gntdev_grant_map *map)
|
||||||
{
|
{
|
||||||
size_t alloced = 0;
|
size_t alloced = 0;
|
||||||
@@ -1102,23 +1087,6 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
|
|||||||
err = vm_map_pages_zero(vma, map->pages, map->count);
|
err = vm_map_pages_zero(vma, map->pages, map->count);
|
||||||
if (err)
|
if (err)
|
||||||
goto out_put_map;
|
goto out_put_map;
|
||||||
} else {
|
|
||||||
#ifdef CONFIG_X86
|
|
||||||
/*
|
|
||||||
* If the PTEs were not made special by the grant map
|
|
||||||
* hypercall, do so here.
|
|
||||||
*
|
|
||||||
* This is racy since the mapping is already visible
|
|
||||||
* to userspace but userspace should be well-behaved
|
|
||||||
* enough to not touch it until the mmap() call
|
|
||||||
* returns.
|
|
||||||
*/
|
|
||||||
if (!xen_feature(XENFEAT_gnttab_map_avail_bits)) {
|
|
||||||
apply_to_page_range(vma->vm_mm, vma->vm_start,
|
|
||||||
vma->vm_end - vma->vm_start,
|
|
||||||
set_grant_ptes_as_special, NULL);
|
|
||||||
}
|
|
||||||
#endif
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
Reference in New Issue
Block a user