Merge branch 'stable-4.6' of git://git.infradead.org/users/pcmoore/audit
Pull audit updates from Paul Moore: "A small set of patches for audit this time; just three in total and one is a spelling fix. The two patches with actual content are designed to help prevent new instances of auditd from displacing an existing, functioning auditd and to generate a log of the attempt. Not to worry, dead/stuck auditd instances can still be replaced by a new instance without problem. Nothing controversial, and everything passes our regression suite" * 'stable-4.6' of git://git.infradead.org/users/pcmoore/audit: audit: Fix typo in comment audit: log failed attempts to change audit_pid configuration audit: stop an old auditd being starved out by a new auditd
This commit is contained in:
@@ -809,6 +809,16 @@ static int audit_set_feature(struct sk_buff *skb)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int audit_replace(pid_t pid)
|
||||
{
|
||||
struct sk_buff *skb = audit_make_reply(0, 0, AUDIT_REPLACE, 0, 0,
|
||||
&pid, sizeof(pid));
|
||||
|
||||
if (!skb)
|
||||
return -ENOMEM;
|
||||
return netlink_unicast(audit_sock, skb, audit_nlk_portid, 0);
|
||||
}
|
||||
|
||||
static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
|
||||
{
|
||||
u32 seq;
|
||||
@@ -870,9 +880,17 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
|
||||
}
|
||||
if (s.mask & AUDIT_STATUS_PID) {
|
||||
int new_pid = s.pid;
|
||||
pid_t requesting_pid = task_tgid_vnr(current);
|
||||
|
||||
if ((!new_pid) && (task_tgid_vnr(current) != audit_pid))
|
||||
if ((!new_pid) && (requesting_pid != audit_pid)) {
|
||||
audit_log_config_change("audit_pid", new_pid, audit_pid, 0);
|
||||
return -EACCES;
|
||||
}
|
||||
if (audit_pid && new_pid &&
|
||||
audit_replace(requesting_pid) != -ECONNREFUSED) {
|
||||
audit_log_config_change("audit_pid", new_pid, audit_pid, 0);
|
||||
return -EEXIST;
|
||||
}
|
||||
if (audit_enabled != AUDIT_OFF)
|
||||
audit_log_config_change("audit_pid", new_pid, audit_pid, 1);
|
||||
audit_pid = new_pid;
|
||||
|
Reference in New Issue
Block a user