xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests: netdevsim: Always initialize 'RET' variable

Browse Source 
The variable is used by log_test() to check if the test case completely
successfully or not. In case it is not initialized at the start of a
test case, it is possible for the test case to fail despite not
encountering any errors.

Example:

```
...
TEST: Trap group statistics                                         [ OK ]
TEST: Trap policer                                                  [FAIL]
	Policer drop counter was not incremented
TEST: Trap policer binding                                          [FAIL]
	Policer drop counter was not incremented
```

Failure of trap_policer_test() caused trap_policer_bind_test() to fail
as well.

Fix by adding missing initialization of the variable.

Fixes: 5fbff58e27 ("selftests: netdevsim: Add test cases for devlink-trap policers")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ido Schimmel
2020-05-21 14:46:17 +03:00
committed by David S. Miller
parent be43224fc0
commit 4d59e59cf4
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh
View File

@@ -264,6 +264,8 @@ trap_policer_test()
local packets_t0 local packets_t0
local packets_t1 local packets_t1
RET=0
if [ $(devlink_trap_policers_num_get) -eq 0 ]; then if [ $(devlink_trap_policers_num_get) -eq 0 ]; then
check_err 1 "Failed to dump policers" check_err 1 "Failed to dump policers"
fi fi
@@ -328,6 +330,8 @@ trap_group_check_policer()
trap_policer_bind_test() trap_policer_bind_test()
{ {
RET=0
devlink trap group set $DEVLINK_DEV group l2_drops policer 1 devlink trap group set $DEVLINK_DEV group l2_drops policer 1
check_err $? "Failed to bind a valid policer" check_err $? "Failed to bind a valid policer"
if [ $(devlink_trap_group_policer_get "l2_drops") -ne 1 ]; then if [ $(devlink_trap_group_policer_get "l2_drops") -ne 1 ]; then