[PATCH] Make most file operations structs in fs/ const
This is a conversion to make the various file_operations structs in fs/ const. Basically a regexp job, with a few manual fixups The goal is both to increase correctness (harder to accidentally write to shared datastructures) and reducing the false sharing of cachelines with things that get dirty in .data (while .rodata is nicely read only and thus cache clean) Signed-off-by: Arjan van de Ven <arjan@infradead.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
@@ -49,11 +49,11 @@ static inline struct bfs_inode_info *BFS_I(struct inode *inode)
|
||||
|
||||
/* file.c */
|
||||
extern struct inode_operations bfs_file_inops;
|
||||
extern struct file_operations bfs_file_operations;
|
||||
extern const struct file_operations bfs_file_operations;
|
||||
extern struct address_space_operations bfs_aops;
|
||||
|
||||
/* dir.c */
|
||||
extern struct inode_operations bfs_dir_inops;
|
||||
extern struct file_operations bfs_dir_operations;
|
||||
extern const struct file_operations bfs_dir_operations;
|
||||
|
||||
#endif /* _FS_BFS_BFS_H */
|
||||
|
@@ -70,7 +70,7 @@ static int bfs_readdir(struct file * f, void * dirent, filldir_t filldir)
|
||||
return 0;
|
||||
}
|
||||
|
||||
struct file_operations bfs_dir_operations = {
|
||||
const struct file_operations bfs_dir_operations = {
|
||||
.read = generic_read_dir,
|
||||
.readdir = bfs_readdir,
|
||||
.fsync = file_fsync,
|
||||
|
@@ -17,7 +17,7 @@
|
||||
#define dprintf(x...)
|
||||
#endif
|
||||
|
||||
struct file_operations bfs_file_operations = {
|
||||
const struct file_operations bfs_file_operations = {
|
||||
.llseek = generic_file_llseek,
|
||||
.read = generic_file_read,
|
||||
.write = generic_file_write,
|
||||
|
Reference in New Issue
Block a user