xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

batman-adv: Use bool as return type for boolean functions

Browse Source 
It is easier to understand that the returned value of a specific function
doesn't have to be 0 when the functions was successful when the actual
return type is bool. This is especially true when all surrounding functions
with return type int use negative values to return the error code.

Reported-by: Nicholas Krause <xerofoify@gmail.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
This commit is contained in:
Sven Eckelmann
2016-02-22 21:02:39 +01:00
committed by Antonio Quartulli
parent f0b94ebccd
commit 4b426b108a
18 changed files with 205 additions and 199 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
net/batman-adv/network-coding.c
View File

@@ -510,10 +510,10 @@ static u32 batadv_nc_hash_choose(const void *data, u32 size)
* @node: node in the local table
* @data2: second object to compare the node to
*
* Return: 1 if the two entry are the same, 0 otherwise
* Return: true if the two entry are the same, false otherwise
*/
static int batadv_nc_hash_compare(const struct hlist_node *node,
const void *data2)
static bool batadv_nc_hash_compare(const struct hlist_node *node,
const void *data2)
{
const struct batadv_nc_path *nc_path1, *nc_path2;
@@ -523,13 +523,13 @@ static int batadv_nc_hash_compare(const struct hlist_node *node,
/* Return 1 if the two keys are identical */
if (memcmp(nc_path1->prev_hop, nc_path2->prev_hop,
sizeof(nc_path1->prev_hop)) != 0)
return 0;
return false;
if (memcmp(nc_path1->next_hop, nc_path2->next_hop,
sizeof(nc_path1->next_hop)) != 0)
return 0;
return false;
return 1;
return true;
}
/**