Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
drm-misc-fixes for v5.0: - Block fb changes for async atomic updates to prevent a use after free. - Fix ID mismatch error on load in bochs. - Fix memory leak when drm_setup fails. - Fixes around handling of DRM_AUTH. Signed-off-by: Dave Airlie <airlied@redhat.com> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/42113611-e2cd-6bdd-7de5-4f8ab5a0cbe6@linux.intel.com
This commit is contained in:
@@ -262,6 +262,18 @@ void drm_file_free(struct drm_file *file)
|
||||
kfree(file);
|
||||
}
|
||||
|
||||
static void drm_close_helper(struct file *filp)
|
||||
{
|
||||
struct drm_file *file_priv = filp->private_data;
|
||||
struct drm_device *dev = file_priv->minor->dev;
|
||||
|
||||
mutex_lock(&dev->filelist_mutex);
|
||||
list_del(&file_priv->lhead);
|
||||
mutex_unlock(&dev->filelist_mutex);
|
||||
|
||||
drm_file_free(file_priv);
|
||||
}
|
||||
|
||||
static int drm_setup(struct drm_device * dev)
|
||||
{
|
||||
int ret;
|
||||
@@ -318,8 +330,10 @@ int drm_open(struct inode *inode, struct file *filp)
|
||||
goto err_undo;
|
||||
if (need_setup) {
|
||||
retcode = drm_setup(dev);
|
||||
if (retcode)
|
||||
if (retcode) {
|
||||
drm_close_helper(filp);
|
||||
goto err_undo;
|
||||
}
|
||||
}
|
||||
return 0;
|
||||
|
||||
@@ -473,11 +487,7 @@ int drm_release(struct inode *inode, struct file *filp)
|
||||
|
||||
DRM_DEBUG("open_count = %d\n", dev->open_count);
|
||||
|
||||
mutex_lock(&dev->filelist_mutex);
|
||||
list_del(&file_priv->lhead);
|
||||
mutex_unlock(&dev->filelist_mutex);
|
||||
|
||||
drm_file_free(file_priv);
|
||||
drm_close_helper(filp);
|
||||
|
||||
if (!--dev->open_count) {
|
||||
drm_lastclose(dev);
|
||||
|
Reference in New Issue
Block a user