xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leds: tca6507: silence an uninitialized variable warning

Browse Source 
If choose_times() returns -EINVAL that means "c1" and "c2" haven't been
initialized.  I've added a check for that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
This commit is contained in:
Dan Carpenter
2016-04-14 12:36:16 +03:00
committed by Jacek Anaszewski
parent fea728c098
commit 4a91c45ea5
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/leds/leds-tca6507.c
View File

@@ -327,6 +327,8 @@ static void set_times(struct tca6507_chip *tca, int bank)
int result; int result;
result = choose_times(tca->bank[bank].ontime, &c1, &c2); result = choose_times(tca->bank[bank].ontime, &c1, &c2);
if (result < 0)
return;
dev_dbg(&tca->client->dev, dev_dbg(&tca->client->dev,
"Chose on times %d(%d) %d(%d) for %dms\n", "Chose on times %d(%d) %d(%d) for %dms\n",
c1, time_codes[c1], c1, time_codes[c1],