ipv6: update ip6_rt_last_gc every time GC is run
As pointed out by Eric Dumazet, net->ipv6.ip6_rt_last_gc should hold the last time garbage collector was run so that we should update it whenever fib6_run_gc() calls fib6_clean_all(), not only if we got there from ip6_dst_gc(). Signed-off-by: Michal Kubecek <mkubecek@suse.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
2ac3ac8f86
commit
49a18d86f6
@@ -1311,7 +1311,6 @@ static void icmp6_clean_all(int (*func)(struct rt6_info *rt, void *arg),
|
||||
|
||||
static int ip6_dst_gc(struct dst_ops *ops)
|
||||
{
|
||||
unsigned long now = jiffies;
|
||||
struct net *net = container_of(ops, struct net, ipv6.ip6_dst_ops);
|
||||
int rt_min_interval = net->ipv6.sysctl.ip6_rt_gc_min_interval;
|
||||
int rt_max_size = net->ipv6.sysctl.ip6_rt_max_size;
|
||||
@@ -1321,13 +1320,12 @@ static int ip6_dst_gc(struct dst_ops *ops)
|
||||
int entries;
|
||||
|
||||
entries = dst_entries_get_fast(ops);
|
||||
if (time_after(rt_last_gc + rt_min_interval, now) &&
|
||||
if (time_after(rt_last_gc + rt_min_interval, jiffies) &&
|
||||
entries <= rt_max_size)
|
||||
goto out;
|
||||
|
||||
net->ipv6.ip6_rt_gc_expire++;
|
||||
fib6_run_gc(net->ipv6.ip6_rt_gc_expire, net, entries > rt_max_size);
|
||||
net->ipv6.ip6_rt_last_gc = now;
|
||||
entries = dst_entries_get_slow(ops);
|
||||
if (entries < ops->gc_thresh)
|
||||
net->ipv6.ip6_rt_gc_expire = rt_gc_timeout>>1;
|
||||
|
Reference in New Issue
Block a user