drivers/net: get rid of unnecessary initializations in .get_drvinfo()
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len, eedump_len & regdump_len fields in their .get_drvinfo() ethtool op. It's not necessary as these fields is filled in ethtool_get_drvinfo(). v2: removed unused variable v3: removed another unused variable Signed-off-by: Ivan Vecera <ivecera@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
这个提交包含在:
@@ -899,7 +899,6 @@ static void cpmac_get_drvinfo(struct net_device *dev,
|
||||
strlcpy(info->driver, "cpmac", sizeof(info->driver));
|
||||
strlcpy(info->version, CPMAC_VERSION, sizeof(info->version));
|
||||
snprintf(info->bus_info, sizeof(info->bus_info), "%s", "cpmac");
|
||||
info->regdump_len = 0;
|
||||
}
|
||||
|
||||
static const struct ethtool_ops cpmac_ethtool_ops = {
|
||||
|
@@ -1784,7 +1784,6 @@ static void cpsw_get_drvinfo(struct net_device *ndev,
|
||||
strlcpy(info->driver, "cpsw", sizeof(info->driver));
|
||||
strlcpy(info->version, "1.0", sizeof(info->version));
|
||||
strlcpy(info->bus_info, priv->pdev->name, sizeof(info->bus_info));
|
||||
info->regdump_len = cpsw_get_regs_len(ndev);
|
||||
}
|
||||
|
||||
static u32 cpsw_get_msglevel(struct net_device *ndev)
|
||||
|
@@ -791,7 +791,6 @@ static void tlan_get_drvinfo(struct net_device *dev,
|
||||
sizeof(info->bus_info));
|
||||
else
|
||||
strlcpy(info->bus_info, "EISA", sizeof(info->bus_info));
|
||||
info->eedump_len = TLAN_EEPROM_SIZE;
|
||||
}
|
||||
|
||||
static int tlan_get_eeprom_len(struct net_device *dev)
|
||||
|
在新工单中引用
屏蔽一个用户