GFS2 fatal: filesystem consistency error on rename
This patch fixes a GFS2 problem whereby the first rename after a mount can result in a file system consistency error being flagged improperly and cause the file system to withdraw. The problem is that the rename code tries to run the rgrp list with function gfs2_blk2rgrpd before the rgrp list is guaranteed to be read in from disk. The patch makes the rename function hold the rindex glock (as the gfs2_unlink code does today) which reads in the rgrp list if need be. There were a total of three places in the rename code that improperly referenced the rgrp list without the rindex glock and this patch fixes all three. Signed-off-by: Bob Peterson <rpeterso@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
This commit is contained in:

committed by
Steven Whitehouse

parent
feb47ca931
commit
46290341cd
@@ -39,10 +39,12 @@ static inline void gfs2_alloc_put(struct gfs2_inode *ip)
|
||||
ip->i_alloc = NULL;
|
||||
}
|
||||
|
||||
extern int gfs2_inplace_reserve_i(struct gfs2_inode *ip, char *file,
|
||||
unsigned int line);
|
||||
extern int gfs2_inplace_reserve_i(struct gfs2_inode *ip, int hold_rindex,
|
||||
char *file, unsigned int line);
|
||||
#define gfs2_inplace_reserve(ip) \
|
||||
gfs2_inplace_reserve_i((ip), __FILE__, __LINE__)
|
||||
gfs2_inplace_reserve_i((ip), 1, __FILE__, __LINE__)
|
||||
#define gfs2_inplace_reserve_ri(ip) \
|
||||
gfs2_inplace_reserve_i((ip), 0, __FILE__, __LINE__)
|
||||
|
||||
extern void gfs2_inplace_release(struct gfs2_inode *ip);
|
||||
|
||||
|
Reference in New Issue
Block a user