xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: greybus: codecs: fix type confusion of list iterator variable

Browse Source 
[ Upstream commit 84ef256550196bc06e6849a34224c998b45bd557 ]

If the list does not exit early then data == NULL and 'module' does not
point to a valid list element.
Using 'module' in such a case is not valid and was therefore removed.

Fixes: 6dd67645f2 ("greybus: audio: Use single codec driver registration")
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220321123626.3068639-1-jakobkoschel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jakob Koschel
2022-03-21 13:36:26 +01:00
committed by Greg Kroah-Hartman
parent 1509d2335d
commit 4610b06761
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/greybus/audio_codec.c
View File

@@ -621,8 +621,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
break; break;
} }
if (!data) { if (!data) {
dev_err(dai->dev, "%s:%s DATA connection missing\n", dev_err(dai->dev, "%s DATA connection missing\n",
dai->name, module->name); dai->name);
mutex_unlock(&codec->lock); mutex_unlock(&codec->lock);
return -ENODEV; return -ENODEV;
} }