xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tty: nozomi: Fix a resource leak in an error handling function

Browse Source 
[ Upstream commit 31a9a318255960d32ae183e95d0999daf2418608 ]

A 'request_irq()' call is not balanced by a corresponding 'free_irq()' in
the error handling path, as already done in the remove function.

Add it.

Fixes: 9842c38e91 ("kfifo: fix warn_unused_result")
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/4f0d2b3038e82f081d370ccb0cade3ad88463fe7.1620580838.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Christophe JAILLET
2021-05-09 19:22:33 +02:00
committed by Greg Kroah-Hartman
parent f5186bd17f
commit 460bee9009
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/tty/nozomi.c
View File

@@ -1436,6 +1436,7 @@ err_free_tty:
tty_unregister_device(ntty_driver, dc->index_start + i); tty_unregister_device(ntty_driver, dc->index_start + i);
tty_port_destroy(&dc->port[i].port); tty_port_destroy(&dc->port[i].port);
} }
free_irq(pdev->irq, dc);
err_free_kfifo: err_free_kfifo:
for (i = 0; i < MAX_PORT; i++) for (i = 0; i < MAX_PORT; i++)
kfifo_free(&dc->port[i].fifo_ul); kfifo_free(&dc->port[i].fifo_ul);