selftest/firmware: Add selftest timeout in settings
The firmware tests would always time out for me. Add a correct timeout, including details on how the value was reached. Additionally allow the test harness to skip comments in settings files and report how long a given timeout was. Reviewed-by: SeongJae Park <sjpark@amazon.de> Acked-by: Scott Branden <scott.branden@broadcom.com> Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20200724213640.389191-3-keescook@chromium.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
2d38dbf89a
commit
4505e2154e
@@ -53,6 +53,10 @@ run_one()
|
||||
settings="$BASE_DIR/$DIR/settings"
|
||||
if [ -r "$settings" ] ; then
|
||||
while read line ; do
|
||||
# Skip comments.
|
||||
if echo "$line" | grep -q '^#'; then
|
||||
continue
|
||||
fi
|
||||
field=$(echo "$line" | cut -d= -f1)
|
||||
value=$(echo "$line" | cut -d= -f2-)
|
||||
eval "kselftest_$field"="$value"
|
||||
@@ -80,7 +84,7 @@ run_one()
|
||||
echo "not ok $test_num $TEST_HDR_MSG # SKIP"
|
||||
elif [ $rc -eq $timeout_rc ]; then \
|
||||
echo "#"
|
||||
echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT"
|
||||
echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT $kselftest_timeout seconds"
|
||||
else
|
||||
echo "not ok $test_num $TEST_HDR_MSG # exit=$rc"
|
||||
fi)
|
||||
|
Reference in New Issue
Block a user