xfs: clean up IRELE/iput callsites

Replace the IRELE macro with a proper function so that we can do proper
typechecking and so that we can stop open-coding iput in scrub, which
means that we'll be able to ftrace inode lifetimes going through scrub
correctly.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
This commit is contained in:
Darrick J. Wong
2018-07-25 12:52:32 -07:00
parent 89c3e8cf3c
commit 44a8736bd2
19 changed files with 54 additions and 49 deletions

View File

@@ -230,11 +230,11 @@ xchk_parent_validate(
/* Drat, parent changed. Try again! */
if (dnum != dp->i_ino) {
iput(VFS_I(dp));
xfs_irele(dp);
*try_again = true;
return 0;
}
iput(VFS_I(dp));
xfs_irele(dp);
/*
* '..' didn't change, so check that there was only one entry
@@ -247,7 +247,7 @@ xchk_parent_validate(
out_unlock:
xfs_iunlock(dp, XFS_IOLOCK_SHARED);
out_rele:
iput(VFS_I(dp));
xfs_irele(dp);
out:
return error;
}