drm/scheduler: only kill entity if last user is killed v2
Note which task is using the entity and only kill it if the last user of the entity is killed. This should prevent problems when entities are leaked to child processes. v2: add missing kernel doc Signed-off-by: Christian König <christian.koenig@amd.com> Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com> Acked-by: Nayan Deshmukh <nayan26deshmukh@gmail.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:

committed by
Alex Deucher

parent
4a102ad4ba
commit
43bce41cf4
@@ -275,6 +275,7 @@ static void drm_sched_entity_kill_jobs_cb(struct dma_fence *f,
|
||||
long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
|
||||
{
|
||||
struct drm_gpu_scheduler *sched;
|
||||
struct task_struct *last_user;
|
||||
long ret = timeout;
|
||||
|
||||
sched = entity->rq->sched;
|
||||
@@ -295,7 +296,9 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
|
||||
|
||||
|
||||
/* For killed process disable any more IBs enqueue right now */
|
||||
if ((current->flags & PF_EXITING) && (current->exit_code == SIGKILL))
|
||||
last_user = cmpxchg(&entity->last_user, current->group_leader, NULL);
|
||||
if ((!last_user || last_user == current->group_leader) &&
|
||||
(current->flags & PF_EXITING) && (current->exit_code == SIGKILL))
|
||||
drm_sched_entity_set_rq(entity, NULL);
|
||||
|
||||
return ret;
|
||||
@@ -541,6 +544,7 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job,
|
||||
|
||||
trace_drm_sched_job(sched_job, entity);
|
||||
|
||||
WRITE_ONCE(entity->last_user, current->group_leader);
|
||||
first = spsc_queue_push(&entity->job_queue, &sched_job->queue_node);
|
||||
|
||||
/* first job wakes up scheduler */
|
||||
|
Reference in New Issue
Block a user