[XFS] remove most calls to VN_RELE
Most VN_RELE calls either directly contain a XFS_ITOV or have the corresponding xfs_inode already in scope. Use the IRELE helper instead of VN_RELE to clarify the code. With a little more work we can kill VN_RELE altogether and define IRELE in terms of iput directly. SGI-PV: 976035 SGI-Modid: xfs-linux-melb:xfs-kern:30710a Signed-off-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
This commit is contained in:

committed by
Lachlan McIlroy

父節點
df26cfe849
當前提交
433550990e
@@ -1810,7 +1810,7 @@ xfs_qm_dqusage_adjust(
|
||||
* Now release the inode. This will send it to 'inactive', and
|
||||
* possibly even free blocks.
|
||||
*/
|
||||
VN_RELE(XFS_ITOV(ip));
|
||||
IRELE(ip);
|
||||
|
||||
/*
|
||||
* Goto next inode.
|
||||
@@ -1968,7 +1968,7 @@ xfs_qm_init_quotainos(
|
||||
if ((error = xfs_iget(mp, NULL, mp->m_sb.sb_gquotino,
|
||||
0, 0, &gip, 0))) {
|
||||
if (uip)
|
||||
VN_RELE(XFS_ITOV(uip));
|
||||
IRELE(uip);
|
||||
return XFS_ERROR(error);
|
||||
}
|
||||
}
|
||||
@@ -1999,7 +1999,7 @@ xfs_qm_init_quotainos(
|
||||
sbflags | XFS_SB_GQUOTINO, flags);
|
||||
if (error) {
|
||||
if (uip)
|
||||
VN_RELE(XFS_ITOV(uip));
|
||||
IRELE(uip);
|
||||
|
||||
return XFS_ERROR(error);
|
||||
}
|
||||
|
@@ -386,7 +386,7 @@ xfs_qm_scall_trunc_qfiles(
|
||||
error = xfs_iget(mp, NULL, mp->m_sb.sb_uquotino, 0, 0, &qip, 0);
|
||||
if (! error) {
|
||||
(void) xfs_truncate_file(mp, qip);
|
||||
VN_RELE(XFS_ITOV(qip));
|
||||
IRELE(qip);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -395,7 +395,7 @@ xfs_qm_scall_trunc_qfiles(
|
||||
error = xfs_iget(mp, NULL, mp->m_sb.sb_gquotino, 0, 0, &qip, 0);
|
||||
if (! error) {
|
||||
(void) xfs_truncate_file(mp, qip);
|
||||
VN_RELE(XFS_ITOV(qip));
|
||||
IRELE(qip);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -552,13 +552,13 @@ xfs_qm_scall_getqstat(
|
||||
out->qs_uquota.qfs_nblks = uip->i_d.di_nblocks;
|
||||
out->qs_uquota.qfs_nextents = uip->i_d.di_nextents;
|
||||
if (tempuqip)
|
||||
VN_RELE(XFS_ITOV(uip));
|
||||
IRELE(uip);
|
||||
}
|
||||
if (gip) {
|
||||
out->qs_gquota.qfs_nblks = gip->i_d.di_nblocks;
|
||||
out->qs_gquota.qfs_nextents = gip->i_d.di_nextents;
|
||||
if (tempgqip)
|
||||
VN_RELE(XFS_ITOV(gip));
|
||||
IRELE(gip);
|
||||
}
|
||||
if (mp->m_quotainfo) {
|
||||
out->qs_incoredqs = XFS_QI_MPLNDQUOTS(mp);
|
||||
@@ -1095,7 +1095,7 @@ again:
|
||||
* inactive code in hell.
|
||||
*/
|
||||
if (vnode_refd)
|
||||
VN_RELE(vp);
|
||||
IRELE(ip);
|
||||
XFS_MOUNT_ILOCK(mp);
|
||||
/*
|
||||
* If an inode was inserted or removed, we gotta
|
||||
|
Reference in New Issue
Block a user