mmap locking API: add mmap_assert_locked() and mmap_assert_write_locked()
Add new APIs to assert that mmap_sem is held. Using this instead of rwsem_is_locked and lockdep_assert_held[_write] makes the assertions more tolerant of future changes to the lock type. Signed-off-by: Michel Lespinasse <walken@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Vlastimil Babka <vbabka@suse.cz> Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com> Cc: Davidlohr Bueso <dbueso@suse.de> Cc: David Rientjes <rientjes@google.com> Cc: Hugh Dickins <hughd@google.com> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Jerome Glisse <jglisse@redhat.com> Cc: John Hubbard <jhubbard@nvidia.com> Cc: Laurent Dufour <ldufour@linux.ibm.com> Cc: Liam Howlett <Liam.Howlett@oracle.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ying Han <yinghan@google.com> Link: http://lkml.kernel.org/r/20200520052908.204642-10-walken@google.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
14c3656b72
commit
42fc541404
@@ -395,7 +395,7 @@ int walk_page_range(struct mm_struct *mm, unsigned long start,
|
||||
if (!walk.mm)
|
||||
return -EINVAL;
|
||||
|
||||
lockdep_assert_held(&walk.mm->mmap_sem);
|
||||
mmap_assert_locked(walk.mm);
|
||||
|
||||
vma = find_vma(walk.mm, start);
|
||||
do {
|
||||
@@ -453,7 +453,7 @@ int walk_page_range_novma(struct mm_struct *mm, unsigned long start,
|
||||
if (start >= end || !walk.mm)
|
||||
return -EINVAL;
|
||||
|
||||
lockdep_assert_held(&walk.mm->mmap_sem);
|
||||
mmap_assert_locked(walk.mm);
|
||||
|
||||
return __walk_page_range(start, end, &walk);
|
||||
}
|
||||
@@ -472,7 +472,7 @@ int walk_page_vma(struct vm_area_struct *vma, const struct mm_walk_ops *ops,
|
||||
if (!walk.mm)
|
||||
return -EINVAL;
|
||||
|
||||
lockdep_assert_held(&walk.mm->mmap_sem);
|
||||
mmap_assert_locked(walk.mm);
|
||||
|
||||
err = walk_page_test(vma->vm_start, vma->vm_end, &walk);
|
||||
if (err > 0)
|
||||
|
Reference in New Issue
Block a user