[PATCH] mm: rss = file_rss + anon_rss
I was lazy when we added anon_rss, and chose to change as few places as possible. So currently each anonymous page has to be counted twice, in rss and in anon_rss. Which won't be so good if those are atomic counts in some configurations. Change that around: keep file_rss and anon_rss separately, and add them together (with get_mm_rss macro) when the total is needed - reading two atomics is much cheaper than updating two atomics. And update anon_rss upfront, typically in memory.c, not tucked away in page_add_anon_rmap. Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:

committed by
Linus Torvalds

parent
404351e67a
commit
4294621f41
@@ -29,7 +29,7 @@ char *task_mem(struct mm_struct *mm, char *buffer)
|
||||
"VmPTE:\t%8lu kB\n",
|
||||
(mm->total_vm - mm->reserved_vm) << (PAGE_SHIFT-10),
|
||||
mm->locked_vm << (PAGE_SHIFT-10),
|
||||
get_mm_counter(mm, rss) << (PAGE_SHIFT-10),
|
||||
get_mm_rss(mm) << (PAGE_SHIFT-10),
|
||||
data << (PAGE_SHIFT-10),
|
||||
mm->stack_vm << (PAGE_SHIFT-10), text, lib,
|
||||
(PTRS_PER_PTE*sizeof(pte_t)*mm->nr_ptes) >> 10);
|
||||
@@ -44,13 +44,11 @@ unsigned long task_vsize(struct mm_struct *mm)
|
||||
int task_statm(struct mm_struct *mm, int *shared, int *text,
|
||||
int *data, int *resident)
|
||||
{
|
||||
int rss = get_mm_counter(mm, rss);
|
||||
|
||||
*shared = rss - get_mm_counter(mm, anon_rss);
|
||||
*shared = get_mm_counter(mm, file_rss);
|
||||
*text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK))
|
||||
>> PAGE_SHIFT;
|
||||
*data = mm->total_vm - mm->shared_vm;
|
||||
*resident = rss;
|
||||
*resident = *shared + get_mm_counter(mm, anon_rss);
|
||||
return mm->total_vm;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user